Mirrored_Repos/yattee
1
0
Fork 0
mirror of https://github.com/yattee/yattee.git synced 2025-11-16 06:58:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve layout stability and disable unwanted animations

Browse Source 
Added height reservation to FavoriteItemView to prevent layout shifts during content loading. Changed HomeView to use LazyVStack for better performance. Converted QueueView from LazyVStack to VStack. Disabled animations on content count changes across multiple views to prevent jarring layout transitions. Added width constraint to stream button in PlaybackSettings.
This commit is contained in:
Arkadiusz Fal
2025-11-14 20:02:07 +01:00
parent 6c3da98465
commit a0a54bced9
6 changed files with 108 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
Shared/Home/FavoriteItemView.swift
View File

@@ -34,7 +34,7 @@ struct FavoriteItemView: View {
var body: some View {
Group {
if isVisible {
VStack(alignment: .leading, spacing: 2) {
VStack(alignment: .leading, spacing: 0) {
itemControl
.contextMenu { contextMenu }
.contentShape(Rectangle())
@@ -64,24 +64,34 @@ struct FavoriteItemView: View {
#else
.padding(.horizontal, 15)
#endif
.frame(height: expectedContentHeight)
} else {
Group {
switch widgetListingStyle {
case .horizontalCells:
HorizontalCells(items: limitedItems)
case .list:
ListView(items: limitedItems)
.padding(.vertical, 10)
#if os(tvOS)
.padding(.leading, 40)
#else
.padding(.horizontal, 15)
#endif
ZStack(alignment: .topLeading) {
// Reserve space immediately to prevent layout shift
Color.clear
.frame(height: expectedContentHeight)
// Actual content renders within the reserved space
Group {
switch widgetListingStyle {
case .horizontalCells:
HorizontalCells(items: limitedItems)
case .list:
ListView(items: limitedItems)
.padding(.vertical, 10)
#if os(tvOS)
.padding(.leading, 40)
#else
.padding(.horizontal, 15)
#endif
}
}
.environment(\.inChannelView, inChannelView)
}
.environment(\.inChannelView, inChannelView)
.animation(nil, value: store.contentItems.count)
}
}
.animation(nil, value: store.contentItems.count)
.contentShape(Rectangle())
.onAppear {
if item.section == .history {
@@ -233,6 +243,23 @@ struct FavoriteItemView: View {
favoritesModel.listingStyle(item)
}
var expectedContentHeight: Double {
switch widgetListingStyle {
case .horizontalCells:
#if os(tvOS)
return 600
#else
return 290
#endif
case .list:
// Approximate height for list view items
let itemCount = favoritesModel.limit(item)
let itemHeight: Double = 70 // Approximate height per item
let padding: Double = 20
return Double(itemCount) * itemHeight + padding
}
}
func loadCacheAndResource(force: Bool = false) {
guard let resource else { return }