Fixes Issue 18

Fixes issue 18
  *  Issue 18 was caused by the file type association icon extraction.  If no file type associations were set up, the object was not defined which resulted in an error
  *  Fix was to check if the object exists prior to looking at values in it
This commit is contained in:
Mr. Brian Gale 2020-06-19 10:06:53 -06:00
parent f0062b7c07
commit bb9de629a1
2 changed files with 10 additions and 7 deletions

View File

@ -18,7 +18,7 @@ Imports System.Runtime.InteropServices
<Assembly: ComVisible(False)> <Assembly: ComVisible(False)>
'The following GUID is for the ID of the typelib if this project is exposed to COM 'The following GUID is for the ID of the typelib if this project is exposed to COM
<Assembly: Guid("fbd55db5-06ea-4e43-92a4-6e96893013cc")> <Assembly: Guid("fbd55db5-06ea-4e43-92a4-6e96893013cc")>
' Version information for an assembly consists of the following four values: ' Version information for an assembly consists of the following four values:
' '
@ -31,5 +31,5 @@ Imports System.Runtime.InteropServices
' by using the '*' as shown below: ' by using the '*' as shown below:
' <Assembly: AssemblyVersion("1.0.*")> ' <Assembly: AssemblyVersion("1.0.*")>
<Assembly: AssemblyVersion("5.4.0.0")> <Assembly: AssemblyVersion("5.4.0.18")>
<Assembly: AssemblyFileVersion("5.4.0.0")> <Assembly: AssemblyFileVersion("5.4.0.18")>

View File

@ -224,10 +224,13 @@ Public Class RemoteAppCreateClientConnection
If ExtractToIco(RemoteApp.IconPath, RemoteApp.IconIndex, IconFilePath) = False Then If ExtractToIco(RemoteApp.IconPath, RemoteApp.IconIndex, IconFilePath) = False Then
MessageBox.Show("Icon could not be created the RemoteApp. RDP file will still be created.", "Warning", MessageBoxButtons.OK, MessageBoxIcon.Exclamation) MessageBox.Show("Icon could not be created the RemoteApp. RDP file will still be created.", "Warning", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
End If End If
For Each FTA As RemoteAppLib.FileTypeAssociation In RemoteApp.FileTypeAssociations ' Check if there are file type associations before trying to work with the file type association icons
Dim ProductFileName = VB.Left(RDPPath, RDPPath.Length - 4) If Not (RemoteApp.FileTypeAssociations Is Nothing) Then
ExtractFTIcon(ProductFileName, FTA) For Each FTA As RemoteAppLib.FileTypeAssociation In RemoteApp.FileTypeAssociations
Next Dim ProductFileName = VB.Left(RDPPath, RDPPath.Length - 4)
ExtractFTIcon(ProductFileName, FTA)
Next
End If
End If End If
Me.Close() Me.Close()
Else Else