mirror of
https://github.com/python-kasa/python-kasa.git
synced 2024-12-22 19:23:34 +00:00
270614aa02
This improves the initial update cycle to fetch the information as early as possible and avoid requesting unnecessary information (like the child component listing) in every subsequent call of `update()`. The initial update performs the following steps: 1. `component_nego` (for components) and `get_device_info` (for common device info) are requested as first, and their results are stored in the internal state to allow individual modules (like colortemp) to access the data during the initialization later on. 2. If `child_device` component is available, the child device list and their components is requested separately to initialize the children. 3. The modules are initialized based on component lists, making the queries available for the regular `update()`. 4. Finally, a query requesting all module-defined queries is executed, including also those that we already did above, like the device info. All subsequent updates will only involve queries that are defined by the supported modules. This also means that we do not currently support adding & removing child devices on the fly. The internal state contains now only the responses for the most recent update (i.e., no component information is directly available anymore, but needs to be accessed separately if needed). If component information is wanted from homeassistant users via diagnostics reports, the diagnostic platform needs to be adapted to acquire this separately.
76 lines
2.3 KiB
Python
76 lines
2.3 KiB
Python
import inspect
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
from kasa.smart.smartchilddevice import SmartChildDevice
|
|
from kasa.smartprotocol import _ChildProtocolWrapper
|
|
|
|
from .conftest import strip_smart
|
|
|
|
|
|
@strip_smart
|
|
def test_childdevice_init(dev, dummy_protocol, mocker):
|
|
"""Test that child devices get initialized and use protocol wrapper."""
|
|
assert len(dev.children) > 0
|
|
|
|
first = dev.children[0]
|
|
assert isinstance(first.protocol, _ChildProtocolWrapper)
|
|
|
|
assert first._info["category"] == "plug.powerstrip.sub-plug"
|
|
assert "position" in first._info
|
|
|
|
|
|
@strip_smart
|
|
async def test_childdevice_update(dev, dummy_protocol, mocker):
|
|
"""Test that parent update updates children."""
|
|
child_info = dev.internal_state["get_child_device_list"]
|
|
child_list = child_info["child_device_list"]
|
|
|
|
assert len(dev.children) == child_info["sum"]
|
|
first = dev.children[0]
|
|
|
|
await dev.update()
|
|
|
|
assert dev._last_update != first._last_update
|
|
assert child_list[0] == first._last_update
|
|
|
|
|
|
@strip_smart
|
|
@pytest.mark.skipif(
|
|
sys.version_info < (3, 11),
|
|
reason="exceptiongroup requires python3.11+",
|
|
)
|
|
async def test_childdevice_properties(dev: SmartChildDevice):
|
|
"""Check that accessing childdevice properties do not raise exceptions."""
|
|
assert len(dev.children) > 0
|
|
|
|
first = dev.children[0]
|
|
|
|
# children do not have children
|
|
assert not first.children
|
|
|
|
def _test_property_getters():
|
|
"""Try accessing all properties and return a list of encountered exceptions."""
|
|
exceptions = []
|
|
properties = inspect.getmembers(
|
|
first.__class__, lambda o: isinstance(o, property)
|
|
)
|
|
for prop in properties:
|
|
name, _ = prop
|
|
# Skip emeter and time properties
|
|
# TODO: needs API cleanup, emeter* should probably be removed in favor
|
|
# of access through features/modules, handling of time* needs decision.
|
|
if name.startswith("emeter_") or name.startswith("time"):
|
|
continue
|
|
try:
|
|
_ = getattr(first, name)
|
|
except Exception as ex:
|
|
exceptions.append(ex)
|
|
|
|
return exceptions
|
|
|
|
exceptions = list(_test_property_getters())
|
|
if exceptions:
|
|
raise ExceptionGroup("Accessing child properties caused exceptions", exceptions)
|