mirror of
https://github.com/python-kasa/python-kasa.git
synced 2024-12-23 03:33:35 +00:00
6a86ffbbba
This will catch common issues with pytest code. * Use `match` when using `pytest.raises()` for base exception types like `TypeError` or `ValueError` * Use tuples for `parametrize()` * Enforces `pytest.raises()` to contain simple statements, using `noqa` to skip this on some cases for now. * Fixes incorrect exception type (valueerror instead of typeerror) for iotdimmer. * Adds check valid types for `iotbulb.set_hsv` and `color` smart module. * Consolidate exception messages for common interface modules.
164 lines
4.7 KiB
Python
164 lines
4.7 KiB
Python
import pytest
|
|
|
|
from kasa import DeviceType
|
|
from kasa.iot import IotDimmer
|
|
|
|
from .conftest import dimmer_iot, handle_turn_on, turn_on
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_brightness(dev):
|
|
await handle_turn_on(dev, False)
|
|
assert dev.is_on is False
|
|
|
|
await dev.set_brightness(99)
|
|
await dev.update()
|
|
assert dev.brightness == 99
|
|
assert dev.is_on is True
|
|
|
|
await dev.set_brightness(0)
|
|
await dev.update()
|
|
assert dev.brightness == 99
|
|
assert dev.is_on is False
|
|
|
|
|
|
@dimmer_iot
|
|
@turn_on
|
|
async def test_set_brightness_transition(dev, turn_on, mocker):
|
|
await handle_turn_on(dev, turn_on)
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
|
|
await dev.set_brightness(99, transition=1000)
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 99, "duration": 1000},
|
|
)
|
|
await dev.update()
|
|
assert dev.brightness == 99
|
|
assert dev.is_on
|
|
|
|
await dev.set_brightness(0, transition=1000)
|
|
await dev.update()
|
|
assert dev.is_on is False
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_brightness_invalid(dev):
|
|
for invalid_brightness in [-1, 101]:
|
|
with pytest.raises(ValueError, match="Invalid brightness"):
|
|
await dev.set_brightness(invalid_brightness)
|
|
|
|
for invalid_type in [0.5, "foo"]:
|
|
with pytest.raises(TypeError, match="Brightness must be an integer"):
|
|
await dev.set_brightness(invalid_type)
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_brightness_invalid_transition(dev):
|
|
for invalid_transition in [-1]:
|
|
with pytest.raises(ValueError, match="Transition value .+? is not valid."):
|
|
await dev.set_brightness(1, transition=invalid_transition)
|
|
for invalid_type in [0.5, "foo"]:
|
|
with pytest.raises(TypeError, match="Transition must be integer"):
|
|
await dev.set_brightness(1, transition=invalid_type)
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_turn_on_transition(dev, mocker):
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
original_brightness = dev.brightness
|
|
|
|
await dev.turn_on(transition=1000)
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": original_brightness, "duration": 1000},
|
|
)
|
|
await dev.update()
|
|
assert dev.is_on
|
|
assert dev.brightness == original_brightness
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_turn_off_transition(dev, mocker):
|
|
await handle_turn_on(dev, True)
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
original_brightness = dev.brightness
|
|
|
|
await dev.turn_off(transition=1000)
|
|
|
|
assert dev.is_off
|
|
assert dev.brightness == original_brightness
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 0, "duration": 1000},
|
|
)
|
|
|
|
|
|
@dimmer_iot
|
|
@turn_on
|
|
async def test_set_dimmer_transition(dev, turn_on, mocker):
|
|
await handle_turn_on(dev, turn_on)
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
|
|
await dev.set_dimmer_transition(99, 1000)
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 99, "duration": 1000},
|
|
)
|
|
await dev.update()
|
|
assert dev.is_on
|
|
assert dev.brightness == 99
|
|
|
|
|
|
@dimmer_iot
|
|
@turn_on
|
|
async def test_set_dimmer_transition_to_off(dev, turn_on, mocker):
|
|
await handle_turn_on(dev, turn_on)
|
|
original_brightness = dev.brightness
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
|
|
await dev.set_dimmer_transition(0, 1000)
|
|
|
|
assert dev.is_off
|
|
assert dev.brightness == original_brightness
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 0, "duration": 1000},
|
|
)
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_dimmer_transition_invalid_brightness(dev):
|
|
for invalid_brightness in [-1, 101]:
|
|
with pytest.raises(ValueError, match="Invalid brightness value: "):
|
|
await dev.set_dimmer_transition(invalid_brightness, 1000)
|
|
|
|
for invalid_type in [0.5, "foo"]:
|
|
with pytest.raises(TypeError, match="Transition must be integer"):
|
|
await dev.set_dimmer_transition(1, invalid_type)
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_dimmer_transition_invalid_transition(dev):
|
|
for invalid_transition in [-1]:
|
|
with pytest.raises(ValueError, match="Transition value .+? is not valid."):
|
|
await dev.set_dimmer_transition(1, transition=invalid_transition)
|
|
for invalid_type in [0.5, "foo"]:
|
|
with pytest.raises(TypeError, match="Transition must be integer"):
|
|
await dev.set_dimmer_transition(1, transition=invalid_type)
|
|
|
|
|
|
@dimmer_iot
|
|
def test_device_type_dimmer(dev):
|
|
assert dev.device_type == DeviceType.Dimmer
|