mirror of
https://github.com/python-kasa/python-kasa.git
synced 2024-12-24 12:13:35 +00:00
6a86ffbbba
This will catch common issues with pytest code. * Use `match` when using `pytest.raises()` for base exception types like `TypeError` or `ValueError` * Use tuples for `parametrize()` * Enforces `pytest.raises()` to contain simple statements, using `noqa` to skip this on some cases for now. * Fixes incorrect exception type (valueerror instead of typeerror) for iotdimmer. * Adds check valid types for `iotbulb.set_hsv` and `color` smart module. * Consolidate exception messages for common interface modules.
58 lines
1.8 KiB
Python
58 lines
1.8 KiB
Python
import pytest
|
|
|
|
from kasa.iot import IotDevice
|
|
from kasa.smart import SmartDevice
|
|
from kasa.tests.conftest import dimmable_iot, get_parent_and_child_modules, parametrize
|
|
|
|
brightness = parametrize("brightness smart", component_filter="brightness")
|
|
|
|
|
|
@brightness
|
|
async def test_brightness_component(dev: SmartDevice):
|
|
"""Test brightness feature."""
|
|
brightness = next(get_parent_and_child_modules(dev, "Brightness"))
|
|
assert brightness
|
|
assert isinstance(dev, SmartDevice)
|
|
assert "brightness" in dev._components
|
|
|
|
# Test getting the value
|
|
feature = brightness._device.features["brightness"]
|
|
assert isinstance(feature.value, int)
|
|
assert feature.value > 1
|
|
assert feature.value <= 100
|
|
|
|
# Test setting the value
|
|
await feature.set_value(10)
|
|
await dev.update()
|
|
assert feature.value == 10
|
|
|
|
with pytest.raises(ValueError, match="out of range"):
|
|
await feature.set_value(feature.minimum_value - 10)
|
|
|
|
with pytest.raises(ValueError, match="out of range"):
|
|
await feature.set_value(feature.maximum_value + 10)
|
|
|
|
|
|
@dimmable_iot
|
|
async def test_brightness_dimmable(dev: IotDevice):
|
|
"""Test brightness feature."""
|
|
assert isinstance(dev, IotDevice)
|
|
assert "brightness" in dev.sys_info or bool(dev.sys_info["is_dimmable"])
|
|
|
|
# Test getting the value
|
|
feature = dev.features["brightness"]
|
|
assert isinstance(feature.value, int)
|
|
assert feature.value > 0
|
|
assert feature.value <= 100
|
|
|
|
# Test setting the value
|
|
await feature.set_value(10)
|
|
await dev.update()
|
|
assert feature.value == 10
|
|
|
|
with pytest.raises(ValueError, match="out of range"):
|
|
await feature.set_value(feature.minimum_value - 10)
|
|
|
|
with pytest.raises(ValueError, match="out of range"):
|
|
await feature.set_value(feature.maximum_value + 10)
|