mirror of
https://github.com/python-kasa/python-kasa.git
synced 2024-12-23 11:43:34 +00:00
db6e335346
PR contains a number of fixes from testing with HA devices: - Fixes a bug with turning the light on and off via `set_state` - Aligns `set_brightness` behaviour across `smart` and `iot` devices such that a value of 0 is off. - Aligns `set_brightness` behaviour for `IotDimmer` such that setting the brightness turns on the device with a transition of 1ms. ([HA comment](https://github.com/home-assistant/core/pull/117839#discussion_r1608720006)) - Fixes a typing issue in `LightState`. - Adds `ColorTempRange` and `HSV` to `__init__.py` - Adds a `state` property to the interface returning `LightState` for validating `set_state` changes. - Adds tests for `set_state`
144 lines
3.8 KiB
Python
144 lines
3.8 KiB
Python
import pytest
|
|
|
|
from kasa import DeviceType
|
|
from kasa.iot import IotDimmer
|
|
|
|
from .conftest import dimmer_iot, handle_turn_on, turn_on
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_brightness(dev):
|
|
await handle_turn_on(dev, False)
|
|
assert dev.is_on is False
|
|
|
|
await dev.set_brightness(99)
|
|
await dev.update()
|
|
assert dev.brightness == 99
|
|
assert dev.is_on is True
|
|
|
|
await dev.set_brightness(0)
|
|
await dev.update()
|
|
assert dev.brightness == 99
|
|
assert dev.is_on is False
|
|
|
|
|
|
@dimmer_iot
|
|
@turn_on
|
|
async def test_set_brightness_transition(dev, turn_on, mocker):
|
|
await handle_turn_on(dev, turn_on)
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
|
|
await dev.set_brightness(99, transition=1000)
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 99, "duration": 1000},
|
|
)
|
|
await dev.update()
|
|
assert dev.brightness == 99
|
|
assert dev.is_on
|
|
|
|
await dev.set_brightness(0, transition=1000)
|
|
await dev.update()
|
|
assert dev.is_on is False
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_brightness_invalid(dev):
|
|
for invalid_brightness in [-1, 101, 0.5]:
|
|
with pytest.raises(ValueError):
|
|
await dev.set_brightness(invalid_brightness)
|
|
|
|
for invalid_transition in [-1, 0.5]:
|
|
with pytest.raises(ValueError):
|
|
await dev.set_brightness(1, transition=invalid_transition)
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_turn_on_transition(dev, mocker):
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
original_brightness = dev.brightness
|
|
|
|
await dev.turn_on(transition=1000)
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": original_brightness, "duration": 1000},
|
|
)
|
|
await dev.update()
|
|
assert dev.is_on
|
|
assert dev.brightness == original_brightness
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_turn_off_transition(dev, mocker):
|
|
await handle_turn_on(dev, True)
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
original_brightness = dev.brightness
|
|
|
|
await dev.turn_off(transition=1000)
|
|
|
|
assert dev.is_off
|
|
assert dev.brightness == original_brightness
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 0, "duration": 1000},
|
|
)
|
|
|
|
|
|
@dimmer_iot
|
|
@turn_on
|
|
async def test_set_dimmer_transition(dev, turn_on, mocker):
|
|
await handle_turn_on(dev, turn_on)
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
|
|
await dev.set_dimmer_transition(99, 1000)
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 99, "duration": 1000},
|
|
)
|
|
await dev.update()
|
|
assert dev.is_on
|
|
assert dev.brightness == 99
|
|
|
|
|
|
@dimmer_iot
|
|
@turn_on
|
|
async def test_set_dimmer_transition_to_off(dev, turn_on, mocker):
|
|
await handle_turn_on(dev, turn_on)
|
|
original_brightness = dev.brightness
|
|
query_helper = mocker.spy(IotDimmer, "_query_helper")
|
|
|
|
await dev.set_dimmer_transition(0, 1000)
|
|
|
|
assert dev.is_off
|
|
assert dev.brightness == original_brightness
|
|
query_helper.assert_called_with(
|
|
mocker.ANY,
|
|
"smartlife.iot.dimmer",
|
|
"set_dimmer_transition",
|
|
{"brightness": 0, "duration": 1000},
|
|
)
|
|
|
|
|
|
@dimmer_iot
|
|
async def test_set_dimmer_transition_invalid(dev):
|
|
for invalid_brightness in [-1, 101, 0.5]:
|
|
with pytest.raises(ValueError):
|
|
await dev.set_dimmer_transition(invalid_brightness, 1000)
|
|
|
|
for invalid_transition in [-1, 0.5]:
|
|
with pytest.raises(ValueError):
|
|
await dev.set_dimmer_transition(1, invalid_transition)
|
|
|
|
|
|
@dimmer_iot
|
|
def test_device_type_dimmer(dev):
|
|
assert dev.device_type == DeviceType.Dimmer
|