3 Commits

Author	SHA1	Message	Date
Steven B.	91bf9bb73d	Fix generate_supported pre commit to run in venv (#1085) ... I noticed after building a new linux instance that running `git commit` when the virtual environment is not active causes the pre-commit to fail, as the `generate_supported` hook is not explicitly configured to run in the virtual env. This PR calls `generate_supported` via the `run-in-env.sh` script.	2024-07-28 20:41:33 +02:00
Steven B.	7416e855f1	Fix mypy pre-commit hook on windows (#1081)	2024-07-25 09:11:48 +01:00
Steven B	416d3118bf	Configure mypy to run in virtual environment and fix resulting issues (#989) ... For some time I've noticed that my IDE is reporting mypy errors that the pre-commit hook is not picking up. This is because [mypy mirror](https://github.com/pre-commit/mirrors-mypy) runs in an isolated pre-commit environment which does not have dependencies installed and it enables `--ignore-missing-imports` to avoid errors. This is [advised against by mypy](https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker) for obvious reasons: > We recommend avoiding --ignore-missing-imports if possible: it’s equivalent to adding a # type: ignore to all unresolved imports in your codebase. This PR configures the mypy pre-commit hook to run in the virtual environment and addresses the additional errors identified as a result. It also introduces a minimal mypy config into the `pyproject.toml` [mypy errors identified without the fixes in this PR](https://github.com/user-attachments/files/15896693/mypyerrors.txt)	2024-06-19 15:07:59 +02:00