Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2025-12-20 19:50:15 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Do not expose child modules on parent devices (#964)

Browse Source 
Removes the logic to expose child modules on parent devices,
which could cause complications with downstream consumers unknowingly duplicating things.
This commit is contained in:
Steven B
2024-06-10 05:59:37 +01:00
committed by GitHub
parent b094e334ca
commit fe0bbf1b98
6 changed files with 34 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
kasa/tests/test_smartdevice.py
View File

@@ -16,6 +16,7 @@ from kasa.smart import SmartDevice
from .conftest import (
device_smart,
get_device_for_fixture_protocol,
get_parent_and_child_modules,
)
@@ -144,11 +145,8 @@ async def test_get_modules():
# Modules on child
module = dummy_device.modules.get("Fan")
assert module
assert module._device != dummy_device
assert module._device._parent == dummy_device
module = dummy_device.modules.get(Module.Fan)
assert module is None
module = next(get_parent_and_child_modules(dummy_device, "Fan"))
assert module
assert module._device != dummy_device
assert module._device._parent == dummy_device