mirror of
https://github.com/python-kasa/python-kasa.git
synced 2025-08-09 20:24:02 +00:00
Implement feature categories (#846)
Initial implementation for feature categories to help downstreams and our cli tool to categorize the data for more user-friendly manner. As more and more information is being exposed through the generic features interface, it is necessary to give some hints to downstreams about how might want to present the information to users. This is not a 1:1 mapping to the homeassistant's mental model, and it will be necessary to fine-tune homeassistant-specific parameters by other means to polish the presentation.
This commit is contained in:
@@ -10,6 +10,7 @@ if TYPE_CHECKING:
|
||||
from .device import Device
|
||||
|
||||
|
||||
# TODO: This is only useful for Feature, so maybe move to Feature.Type?
|
||||
class FeatureType(Enum):
|
||||
"""Type to help decide how to present the feature."""
|
||||
|
||||
@@ -24,6 +25,22 @@ class FeatureType(Enum):
|
||||
class Feature:
|
||||
"""Feature defines a generic interface for device features."""
|
||||
|
||||
class Category(Enum):
|
||||
"""Category hint for downstreams."""
|
||||
|
||||
#: Primary features control the device state directly.
|
||||
#: Examples including turning the device on, or adjust its brightness.
|
||||
Primary = auto()
|
||||
#: Config features change device behavior without immediate state changes.
|
||||
Config = auto()
|
||||
#: Informative/sensor features deliver some potentially interesting information.
|
||||
Info = auto()
|
||||
#: Debug features deliver more verbose information then informative features.
|
||||
#: You may want to hide these per default to avoid cluttering your UI.
|
||||
Debug = auto()
|
||||
#: The default category if none is specified.
|
||||
Unset = -1
|
||||
|
||||
#: Device instance required for getting and setting values
|
||||
device: Device
|
||||
#: User-friendly short description
|
||||
@@ -38,6 +55,8 @@ class Feature:
|
||||
icon: str | None = None
|
||||
#: Unit, if applicable
|
||||
unit: str | None = None
|
||||
#: Category hint for downstreams
|
||||
category: Feature.Category = Category.Unset
|
||||
#: Type of the feature
|
||||
type: FeatureType = FeatureType.Sensor
|
||||
|
||||
@@ -50,14 +69,29 @@ class Feature:
|
||||
#: If set, this property will be used to set *minimum_value* and *maximum_value*.
|
||||
range_getter: str | None = None
|
||||
|
||||
#: Identifier
|
||||
id: str | None = None
|
||||
|
||||
def __post_init__(self):
|
||||
"""Handle late-binding of members."""
|
||||
# Set id, if unset
|
||||
if self.id is None:
|
||||
self.id = self.name.lower().replace(" ", "_")
|
||||
|
||||
# Populate minimum & maximum values, if range_getter is given
|
||||
container = self.container if self.container is not None else self.device
|
||||
if self.range_getter is not None:
|
||||
self.minimum_value, self.maximum_value = getattr(
|
||||
container, self.range_getter
|
||||
)
|
||||
|
||||
# Set the category, if unset
|
||||
if self.category is Feature.Category.Unset:
|
||||
if self.attribute_setter:
|
||||
self.category = Feature.Category.Config
|
||||
else:
|
||||
self.category = Feature.Category.Info
|
||||
|
||||
@property
|
||||
def value(self):
|
||||
"""Return the current value."""
|
||||
@@ -79,3 +113,13 @@ class Feature:
|
||||
|
||||
container = self.container if self.container is not None else self.device
|
||||
return await getattr(container, self.attribute_setter)(value)
|
||||
|
||||
def __repr__(self):
|
||||
s = f"{self.name} ({self.id}): {self.value}"
|
||||
if self.unit is not None:
|
||||
s += f" {self.unit}"
|
||||
|
||||
if self.type == FeatureType.Number:
|
||||
s += f" (range: {self.minimum_value}-{self.maximum_value})"
|
||||
|
||||
return s
|
||||
|
Reference in New Issue
Block a user