Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2026-10-07 05:13:49 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

tests: add type annotations to top-level test files (#1688)

Browse Source 
Add type annotations (parameter types and `-> None` return types) to all
top-level test functions across 22 test files. This enables mypy to
check test function bodies, catching type errors that were previously
hidden.
This commit is contained in:
ZeliardM
2026-10-04 10:36:01 -04:00
committed by GitHub
parent eed64fe013
commit b36c795cbc
22 changed files with 557 additions and 392 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/test_device_factory.py
View File

@@ -11,6 +11,7 @@ from typing import cast
import aiohttp
import pytest # type: ignore # https://github.com/pytest-dev/pytest/issues/3342
from pytest_mock import MockerFixture
from kasa import (
BaseProtocol,
@@ -57,7 +58,7 @@ from .conftest import DISCOVERY_MOCK_IP
pytestmark = [pytest.mark.requires_dummy]
def _get_connection_type_device_class(discovery_info):
def _get_connection_type_device_class(discovery_info: dict):
if "result" in discovery_info:
device_class = Discover._get_device_class(discovery_info)
dr = DiscoveryResult.from_dict(discovery_info["result"])
@@ -74,8 +75,8 @@ def _get_connection_type_device_class(discovery_info):
async def test_connect(
discovery_mock,
mocker,
):
mocker: MockerFixture,
) -> None:
"""Test that if the protocol is passed in it gets set correctly."""
host = DISCOVERY_MOCK_IP
ctype, device_class = _get_connection_type_device_class(
@@ -102,7 +103,9 @@ async def test_connect(
@pytest.mark.parametrize("custom_port", [123, None])
async def test_connect_custom_port(discovery_mock, mocker, custom_port):
async def test_connect_custom_port(
discovery_mock, mocker: MockerFixture, custom_port: int | None
) -> None:
"""Make sure that connect returns an initialized SmartDevice instance."""
host = DISCOVERY_MOCK_IP
@@ -127,7 +130,7 @@ async def test_connect_custom_port(discovery_mock, mocker, custom_port):
async def test_connect_logs_connect_time(
discovery_mock,
caplog: pytest.LogCaptureFixture,
):
) -> None:
"""Test that the connect time is logged when debug logging is enabled."""
discovery_data = discovery_mock.discovery_data
ctype, _ = _get_connection_type_device_class(discovery_data)
@@ -143,7 +146,7 @@ async def test_connect_logs_connect_time(
assert "seconds to update" in caplog.text
async def test_connect_query_fails(discovery_mock, mocker):
async def test_connect_query_fails(discovery_mock, mocker: MockerFixture) -> None:
"""Make sure that connect fails when query fails."""
host = DISCOVERY_MOCK_IP
discovery_data = discovery_mock.discovery_data
@@ -162,7 +165,7 @@ async def test_connect_query_fails(discovery_mock, mocker):
assert close_mock.call_count == 1
async def test_connect_http_client(discovery_mock, mocker):
async def test_connect_http_client(discovery_mock, mocker: MockerFixture) -> None:
"""Make sure that discover_single returns an initialized SmartDevice instance."""
host = DISCOVERY_MOCK_IP
discovery_data = discovery_mock.discovery_data
@@ -175,7 +178,8 @@ async def test_connect_http_client(discovery_mock, mocker):
)
dev = await connect(config=config)
if ctype.encryption_type != DeviceEncryptionType.Xor:
assert dev.protocol._transport._http_client.client != http_client
http_client_wrap = dev.protocol._transport._http_client # type: ignore[attr-defined]
assert http_client_wrap.client != http_client
await dev.disconnect()
config = DeviceConfig(
@@ -186,12 +190,13 @@ async def test_connect_http_client(discovery_mock, mocker):
)
dev = await connect(config=config)
if ctype.encryption_type != DeviceEncryptionType.Xor:
assert dev.protocol._transport._http_client.client == http_client
http_client_wrap = dev.protocol._transport._http_client # type: ignore[attr-defined]
assert http_client_wrap.client == http_client
await dev.disconnect()
await http_client.close()
async def test_device_types(dev: Device):
async def test_device_types(dev: Device) -> None:
await dev.update()
if isinstance(dev, SmartCamDevice):
res = SmartCamDevice._get_device_type_from_sysinfo(dev.sys_info)
@@ -208,7 +213,9 @@ async def test_device_types(dev: Device):
@pytest.mark.xdist_group(name="caplog")
async def test_device_class_from_unknown_family(caplog):
async def test_device_class_from_unknown_family(
caplog: pytest.LogCaptureFixture,
) -> None:
"""Verify that unknown SMART devices yield a warning and fallback to SmartDevice."""
dummy_name = "SMART.foo"
with caplog.at_level(logging.DEBUG):
@@ -303,7 +310,7 @@ async def test_get_protocol(
conn_params: DeviceConnectionParameters,
expected_protocol: type[BaseProtocol],
expected_transport: type[BaseTransport],
):
) -> None:
"""Test get_protocol returns the right protocol."""
config = DeviceConfig("127.0.0.1", connection_type=conn_params)
protocol = get_protocol(config)