Create common interfaces for remaining device types (#895)

Introduce common module interfaces across smart and iot devices and provide better typing implementation for getting modules to support this.

kasa/tests/smart/features/test_brightness.py

@@ -10,7 +10,7 @@ brightness = parametrize("brightness smart", component_filter="brightness")
 @brightness
 async def test_brightness_component(dev: SmartDevice):
     """Test brightness feature."""
-    brightness = dev.get_module("Brightness")
+    brightness = dev.modules.get("Brightness")
     assert brightness
     assert isinstance(dev, SmartDevice)
     assert "brightness" in dev._components

kasa/tests/smart/modules/test_contact.py

@@ -1,7 +1,6 @@
 import pytest
 
-from kasa import SmartDevice
-from kasa.smart.modules import ContactSensor
+from kasa import Module, SmartDevice
 from kasa.tests.device_fixtures import parametrize
 
 contact = parametrize(
@@ -18,7 +17,7 @@ contact = parametrize(
 )
 async def test_contact_features(dev: SmartDevice, feature, type):
     """Test that features are registered and work as expected."""
-    contact = dev.get_module(ContactSensor)
+    contact = dev.modules.get(Module.ContactSensor)
     assert contact is not None
 
     prop = getattr(contact, feature)

kasa/tests/smart/modules/test_fan.py

@@ -1,8 +1,8 @@
 import pytest
 from pytest_mock import MockerFixture
 
+from kasa import Module
 from kasa.smart import SmartDevice
-from kasa.smart.modules import FanModule
 from kasa.tests.device_fixtures import parametrize
 
 fan = parametrize("has fan", component_filter="fan_control", protocol_filter={"SMART"})
@@ -11,7 +11,7 @@ fan = parametrize("has fan", component_filter="fan_control", protocol_filter={"S
 @fan
 async def test_fan_speed(dev: SmartDevice, mocker: MockerFixture):
     """Test fan speed feature."""
-    fan = dev.get_module(FanModule)
+    fan = dev.modules.get(Module.Fan)
     assert fan
 
     level_feature = fan._module_features["fan_speed_level"]
@@ -36,7 +36,7 @@ async def test_fan_speed(dev: SmartDevice, mocker: MockerFixture):
 @fan
 async def test_sleep_mode(dev: SmartDevice, mocker: MockerFixture):
     """Test sleep mode feature."""
-    fan = dev.get_module(FanModule)
+    fan = dev.modules.get(Module.Fan)
     assert fan
     sleep_feature = fan._module_features["fan_sleep_mode"]
     assert isinstance(sleep_feature.value, bool)
@@ -55,7 +55,7 @@ async def test_sleep_mode(dev: SmartDevice, mocker: MockerFixture):
 async def test_fan_interface(dev: SmartDevice, mocker: MockerFixture):
     """Test fan speed on device interface."""
     assert isinstance(dev, SmartDevice)
-    fan = dev.get_module(FanModule)
+    fan = dev.modules.get(Module.Fan)
     assert fan
     device = fan._device
     assert device.is_fan

kasa/tests/smart/modules/test_firmware.py

@@ -6,8 +6,8 @@ import logging
 import pytest
 from pytest_mock import MockerFixture
 
+from kasa import Module
 from kasa.smart import SmartDevice
-from kasa.smart.modules import Firmware
 from kasa.smart.modules.firmware import DownloadState
 from kasa.tests.device_fixtures import parametrize
 
@@ -31,7 +31,7 @@ async def test_firmware_features(
     dev: SmartDevice, feature, prop_name, type, required_version, mocker: MockerFixture
 ):
     """Test light effect."""
-    fw = dev.get_module(Firmware)
+    fw = dev.modules.get(Module.Firmware)
     assert fw
 
     if not dev.is_cloud_connected:
@@ -51,7 +51,7 @@ async def test_firmware_features(
 @firmware
 async def test_update_available_without_cloud(dev: SmartDevice):
     """Test that update_available returns None when disconnected."""
-    fw = dev.get_module(Firmware)
+    fw = dev.modules.get(Module.Firmware)
     assert fw
 
     if dev.is_cloud_connected:
@@ -67,7 +67,7 @@ async def test_firmware_update(
     """Test updating firmware."""
     caplog.set_level(logging.INFO)
 
-    fw = dev.get_module(Firmware)
+    fw = dev.modules.get(Module.Firmware)
     assert fw
 
     upgrade_time = 5

kasa/tests/smart/modules/test_light_effect.py

@@ -1,12 +1,11 @@
 from __future__ import annotations
 
 from itertools import chain
-from typing import cast
 
 import pytest
 from pytest_mock import MockerFixture
 
-from kasa import Device, Feature
+from kasa import Device, Feature, Module
 from kasa.smart.modules import LightEffectModule
 from kasa.tests.device_fixtures import parametrize
 
@@ -18,8 +17,8 @@ light_effect = parametrize(
 @light_effect
 async def test_light_effect(dev: Device, mocker: MockerFixture):
     """Test light effect."""
-    light_effect = cast(LightEffectModule, dev.modules.get("LightEffectModule"))
-    assert light_effect
+    light_effect = dev.modules.get(Module.LightEffect)
+    assert isinstance(light_effect, LightEffectModule)
 
     feature = light_effect._module_features["light_effect"]
     assert feature.type == Feature.Type.Choice