Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2025-10-21 06:48:05 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Steven B
2025-01-23 17:34:00 +00:00
parent 1c1c0dcb8c
commit 86e1f5ae38
3 changed files with 92 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
tests/smart/modules/test_powerprotection.py
View File

@@ -2,9 +2,8 @@ import pytest
from pytest_mock import MockerFixture
from kasa import Module, SmartDevice
from kasa.smart.modules import PowerProtection
from ...device_fixtures import parametrize
from ...device_fixtures import get_parent_and_child_modules, parametrize
powerprotection = parametrize(
"has powerprotection",
@@ -13,30 +12,24 @@ powerprotection = parametrize(
)
def _skip_on_unavailable(dev: SmartDevice):
if Module.PowerProtection not in dev.modules:
pytest.skip(f"No powerprotection module on {dev}, maybe a strip parent?")
@powerprotection
@pytest.mark.parametrize(
("feature", "prop_name", "type"),
[
("overloaded", "overloaded", bool),
("power_protection_enabled", "enabled", bool),
("power_protection_threshold", "protection_threshold", int),
],
)
async def test_features(dev, feature, prop_name, type):
"""Test that features are registered and work as expected."""
_skip_on_unavailable(dev)
powerprot: PowerProtection = dev.modules[Module.PowerProtection]
powerprot = next(get_parent_and_child_modules(dev, Module.PowerProtection))
assert powerprot
device = powerprot._device
prop = getattr(powerprot, prop_name)
assert isinstance(prop, type)
feat = dev.features[feature]
feat = device.features[feature]
assert feat.value == prop
assert isinstance(feat.value, type)
@@ -44,25 +37,54 @@ async def test_features(dev, feature, prop_name, type):
@powerprotection
async def test_set_enable(dev: SmartDevice, mocker: MockerFixture):
"""Test enable."""
_skip_on_unavailable(dev)
powerprot = next(get_parent_and_child_modules(dev, Module.PowerProtection))
assert powerprot
device = powerprot._device
powerprot: PowerProtection = dev.modules[Module.PowerProtection]
original_enabled = powerprot.enabled
original_threshold = powerprot.protection_threshold
call_spy = mocker.spy(powerprot, "call")
await powerprot.set_enabled(True)
params = {
"enabled": mocker.ANY,
"protection_power": mocker.ANY,
}
call_spy.assert_called_with("set_protection_power", params)
try:
# Simple enable with an existing threshold
call_spy = mocker.spy(powerprot, "call")
await powerprot.set_enabled(True)
params = {
"enabled": True,
"protection_power": mocker.ANY,
}
call_spy.assert_called_with("set_protection_power", params)
# Enable with no threshold param when 0
call_spy.reset_mock()
await powerprot.set_protection_threshold(0)
await device.update()
await powerprot.set_enabled(True)
params = {
"enabled": True,
"protection_power": int(powerprot._max_power / 2),
}
call_spy.assert_called_with("set_protection_power", params)
# Enable false should not update the threshold
call_spy.reset_mock()
await powerprot.set_protection_threshold(0)
await device.update()
await powerprot.set_enabled(False)
params = {
"enabled": False,
"protection_power": 0,
}
call_spy.assert_called_with("set_protection_power", params)
finally:
await powerprot.set_enabled(original_enabled, threshold=original_threshold)
@powerprotection
async def test_set_threshold(dev: SmartDevice, mocker: MockerFixture):
"""Test enable."""
_skip_on_unavailable(dev)
powerprot: PowerProtection = dev.modules[Module.PowerProtection]
powerprot = next(get_parent_and_child_modules(dev, Module.PowerProtection))
assert powerprot
call_spy = mocker.spy(powerprot, "call")
await powerprot.set_protection_threshold(123)