Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2024-12-23 03:33:35 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Backwards compatible with smart

Browse Source
This commit is contained in:
sdb9696 2024-06-29 09:29:57 +01:00
parent 77ac6ca148
commit 6e62a463ea
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kasa/smart/smartdevice.py
View File

@ -161,7 +161,9 @@ class SmartDevice(Device):
DeprecationWarning,
stacklevel=1,
)
update_children_or_parent = update_children
# Previously this was ignored and children were always updated for
# smart devices
update_children_or_parent = True
await self._update(update_children_or_parent)

9
kasa/tests/test_childdevice.py
View File

@ -6,6 +6,7 @@ from pytest_mock import MockerFixture
from kasa import Device
from kasa.device_type import DeviceType
from kasa.iot import IotDevice
from kasa.smart.smartchilddevice import SmartChildDevice
from kasa.smart.smartdevice import NON_HUB_PARENT_ONLY_MODULES
from kasa.smartprotocol import _ChildProtocolWrapper
@ -190,7 +191,8 @@ async def test_device_updates_deprecated(
for child_spy in child_spies.values():
child_spy.assert_called_once()
# do not update children, only parent calls update
# do not update children, only parent calls update for iot but for smart
# all children update
parent_spy.reset_mock()
for child_spy in child_spies.values():
child_spy.reset_mock()
@ -199,7 +201,10 @@ async def test_device_updates_deprecated(
await dev.update(update_children_or_parent, update_children=False)
parent_spy.assert_called_once()
for child_spy in child_spies.values():
child_spy.assert_not_called()
if isinstance(dev, IotDevice):
child_spy.assert_not_called()
else:
child_spy.assert_called_once()
# on child update_children true
# only the child and no parent update