mirror of
https://github.com/python-kasa/python-kasa.git
synced 2025-10-19 05:48:02 +00:00
Add flake8-pytest-style (PT) for ruff (#1105)
This will catch common issues with pytest code. * Use `match` when using `pytest.raises()` for base exception types like `TypeError` or `ValueError` * Use tuples for `parametrize()` * Enforces `pytest.raises()` to contain simple statements, using `noqa` to skip this on some cases for now. * Fixes incorrect exception type (valueerror instead of typeerror) for iotdimmer. * Adds check valid types for `iotbulb.set_hsv` and `color` smart module. * Consolidate exception messages for common interface modules.
This commit is contained in:
@@ -100,7 +100,7 @@ async def test_login(mocker, status_code, error_code, inner_error_code, expectat
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"inner_error_codes, expectation, call_count",
|
||||
("inner_error_codes", "expectation", "call_count"),
|
||||
[
|
||||
([SmartErrorCode.LOGIN_ERROR, 0, 0, 0], does_not_raise(), 4),
|
||||
(
|
||||
@@ -298,7 +298,7 @@ async def test_unknown_errors(mocker, error_code):
|
||||
"requestID": 1,
|
||||
"terminal_uuid": "foobar",
|
||||
}
|
||||
with pytest.raises(KasaException):
|
||||
with pytest.raises(KasaException): # noqa: PT012
|
||||
res = await transport.send(json_dumps(request))
|
||||
assert res is SmartErrorCode.INTERNAL_UNKNOWN_ERROR
|
||||
|
||||
@@ -315,7 +315,7 @@ async def test_port_override():
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"device_delay_required, should_error, should_succeed",
|
||||
("device_delay_required", "should_error", "should_succeed"),
|
||||
[
|
||||
pytest.param(0, False, True, id="No error"),
|
||||
pytest.param(0.125, True, True, id="Error then succeed"),
|
||||
|
Reference in New Issue
Block a user