Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2025-11-28 20:28:14 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add flake8-pytest-style (PT) for ruff (#1105)

Browse Source 
This will catch common issues with pytest code.

* Use `match` when using `pytest.raises()` for base exception types like
`TypeError` or `ValueError`
* Use tuples for `parametrize()`
* Enforces `pytest.raises()` to contain simple statements, using `noqa`
to skip this on some cases for now.
* Fixes incorrect exception type (valueerror instead of typeerror) for
iotdimmer.
* Adds check valid types for `iotbulb.set_hsv` and `color` smart module.
* Consolidate exception messages for common interface modules.
This commit is contained in:
Teemu R.
2024-08-30 17:30:07 +02:00
committed by GitHub
parent 3e43781bb2
commit 6a86ffbbba
36 changed files with 248 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kasa/tests/smart/modules/test_fan.py
View File

@@ -76,8 +76,8 @@ async def test_fan_module(dev: SmartDevice, mocker: MockerFixture):
await dev.update()
assert not device.is_on
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="Invalid level"):
await fan.set_fan_speed_level(-1)
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="Invalid level"):
await fan.set_fan_speed_level(5)