Add flake8-pytest-style (PT) for ruff (#1105)

This will catch common issues with pytest code.

* Use `match` when using `pytest.raises()` for base exception types like
`TypeError` or `ValueError`
* Use tuples for `parametrize()`
* Enforces `pytest.raises()` to contain simple statements, using `noqa`
to skip this on some cases for now.
* Fixes incorrect exception type (valueerror instead of typeerror) for
iotdimmer.
* Adds check valid types for `iotbulb.set_hsv` and `color` smart module.
* Consolidate exception messages for common interface modules.
This commit is contained in:
Teemu R.
2024-08-30 17:30:07 +02:00
committed by GitHub
parent 3e43781bb2
commit 6a86ffbbba
36 changed files with 248 additions and 150 deletions

View File

@@ -18,17 +18,18 @@ async def test_brightness_component(dev: SmartDevice):
# Test getting the value
feature = brightness._device.features["brightness"]
assert isinstance(feature.value, int)
assert feature.value > 1 and feature.value <= 100
assert feature.value > 1
assert feature.value <= 100
# Test setting the value
await feature.set_value(10)
await dev.update()
assert feature.value == 10
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="out of range"):
await feature.set_value(feature.minimum_value - 10)
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="out of range"):
await feature.set_value(feature.maximum_value + 10)
@@ -41,15 +42,16 @@ async def test_brightness_dimmable(dev: IotDevice):
# Test getting the value
feature = dev.features["brightness"]
assert isinstance(feature.value, int)
assert feature.value > 0 and feature.value <= 100
assert feature.value > 0
assert feature.value <= 100
# Test setting the value
await feature.set_value(10)
await dev.update()
assert feature.value == 10
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="out of range"):
await feature.set_value(feature.minimum_value - 10)
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="out of range"):
await feature.set_value(feature.maximum_value + 10)

View File

@@ -23,8 +23,8 @@ async def test_colortemp_component(dev: SmartDevice):
await dev.update()
assert feature.value == new_value
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="out of range"):
await feature.set_value(feature.minimum_value - 10)
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="out of range"):
await feature.set_value(feature.maximum_value + 10)