mirror of
https://github.com/python-kasa/python-kasa.git
synced 2025-08-09 20:24:02 +00:00
Add flake8-pytest-style (PT) for ruff (#1105)
This will catch common issues with pytest code. * Use `match` when using `pytest.raises()` for base exception types like `TypeError` or `ValueError` * Use tuples for `parametrize()` * Enforces `pytest.raises()` to contain simple statements, using `noqa` to skip this on some cases for now. * Fixes incorrect exception type (valueerror instead of typeerror) for iotdimmer. * Adds check valid types for `iotbulb.set_hsv` and `color` smart module. * Consolidate exception messages for common interface modules.
This commit is contained in:
@@ -90,7 +90,7 @@ class LightEffect(SmartModule, SmartLightEffect):
|
||||
"""
|
||||
if effect != self.LIGHT_EFFECTS_OFF and effect not in self._scenes_names_to_id:
|
||||
raise ValueError(
|
||||
f"Cannot set light effect to {effect}, possible values "
|
||||
f"The effect {effect} is not a built in effect. Possible values "
|
||||
f"are: {self.LIGHT_EFFECTS_OFF} "
|
||||
f"{' '.join(self._scenes_names_to_id.keys())}"
|
||||
)
|
||||
|
Reference in New Issue
Block a user