Do not crash on missing build number in fw version (#1500)

Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>

kasa/cli/device.py

@@ -48,7 +48,7 @@ async def state(ctx, dev: Device):
     )
     echo(
         f"Firmware:     {dev.device_info.firmware_version}"
-        f" {dev.device_info.firmware_build}"
+        f"{' ' + build if (build := dev.device_info.firmware_build) else ''}"
     )
     echo(f"MAC (rssi):   {dev.mac} ({dev.rssi})")
     if verbose:

kasa/device.py

@@ -161,7 +161,7 @@ class DeviceInfo:
     device_type: DeviceType
     hardware_version: str
     firmware_version: str
-    firmware_build: str
+    firmware_build: str | None
     requires_auth: bool
     region: str | None
 

kasa/iot/iotdevice.py

@@ -760,7 +760,10 @@ class IotDevice(Device):
         device_family = sys_info.get("type", sys_info.get("mic_type"))
         device_type = IotDevice._get_device_type_from_sys_info(info)
         fw_version_full = sys_info["sw_ver"]
-        firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        if " " in fw_version_full:
+            firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        else:
+            firmware_version, firmware_build = fw_version_full, None
         auth = bool(discovery_info and ("mgt_encrypt_schm" in discovery_info))
 
         return DeviceInfo(

kasa/smart/smartdevice.py

@@ -913,7 +913,10 @@ class SmartDevice(Device):
             components, device_family
         )
         fw_version_full = di["fw_ver"]
-        firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        if " " in fw_version_full:
+            firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        else:
+            firmware_version, firmware_build = fw_version_full, None
         _protocol, devicetype = device_family.split(".")
         # Brand inferred from SMART.KASAPLUG/SMART.TAPOPLUG etc.
         brand = devicetype[:4].lower()

kasa/smartcam/smartcamchild.py

@@ -103,7 +103,10 @@ class SmartCamChild(SmartChildDevice, SmartCamDevice):
         model = cifp["device_model"]
         device_type = SmartCamDevice._get_device_type_from_sysinfo(cifp)
         fw_version_full = cifp["sw_ver"]
-        firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        if " " in fw_version_full:
+            firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        else:
+            firmware_version, firmware_build = fw_version_full, None
         return DeviceInfo(
             short_name=model,
             long_name=model,

kasa/smartcam/smartcamdevice.py

@@ -47,7 +47,10 @@ class SmartCamDevice(SmartDevice):
         long_name = discovery_info["device_model"] if discovery_info else short_name
         device_type = SmartCamDevice._get_device_type_from_sysinfo(basic_info)
         fw_version_full = basic_info["sw_version"]
-        firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        if " " in fw_version_full:
+            firmware_version, firmware_build = fw_version_full.split(" ", maxsplit=1)
+        else:
+            firmware_version, firmware_build = fw_version_full, None
         return DeviceInfo(
             short_name=basic_info["device_model"],
             long_name=long_name,