diff --git a/kasa/cli.py b/kasa/cli.py index 5a60bf19..dce38def 100755 --- a/kasa/cli.py +++ b/kasa/cli.py @@ -1301,7 +1301,7 @@ async def firmware_update(ctx: click.Context, dev: Device): echo(f"Progress: {x}") echo("Going to update %s", dev) - await dev.modules.get[Module.Firmware].update_firmware(progress_cb=progress) # type: ignore + await dev.modules[Module.Firmware].update_firmware(progress_cb=progress) # type: ignore if __name__ == "__main__": diff --git a/kasa/smart/modules/firmware.py b/kasa/smart/modules/firmware.py index 20722122..cdad5f6a 100644 --- a/kasa/smart/modules/firmware.py +++ b/kasa/smart/modules/firmware.py @@ -228,8 +228,7 @@ class Firmware(SmartModule, FirmwareInterface): | None = None, ) -> UpdateResult: """Update the firmware.""" - # TODO: implement, this is part of the common firmware API - raise NotImplementedError + return await self.update(progress_cb) async def check_for_updates(self) -> FirmwareUpdateInfoInterface: """Return firmware update information."""