Do not authenticate with a credentials_hash from a different transport (#1749)

A `credentials_hash` is specific to the transport that produced it, but
nothing checked that the hash a transport was handed was its own.

This matters because a device can change its encryption type without the
credentials changing. For example, toggling **Third-Party Compatibility** in the Tapo
app moves a plug or strip between TPAP and KLAP, and firmware updates are known to introduce new transports.

This introduces a per-transport check that the hash has the shape that transport produces, and treats a foreign hash as absent rather than as a bad password. This makes the failure honest but still ends in a reauth.

This also changes how credentials are read back out when the hash is one of the plaintext forms and lets the transport derive its own, so the change of encryption type needs no reauth in all cases.
This commit is contained in:
nopoz
2026-10-04 06:30:01 -07:00
committed by GitHub
parent b0d77b35a2
commit 53823ea9a5
7 changed files with 319 additions and 0 deletions

View File

@@ -5,6 +5,8 @@ from __future__ import annotations
import base64
from dataclasses import dataclass, field
from kasa.json import loads as json_loads
@dataclass
class Credentials:
@@ -15,6 +17,28 @@ class Credentials:
#: Password of the cloud account
password: str = field(default="", repr=False)
@classmethod
def _from_plaintext_hash(cls, credentials_hash: str) -> Credentials | None:
"""Recover the credentials from a hash that stores them in plaintext.
The ssl aes and tpap transports store base64 json of the plaintext
credentials, so a transport handed one of those after a device changed
its encryption type can derive its own hash rather than failing to
authenticate. Klap and aes hashes are one way, so this only works in
that direction.
"""
try:
decoded = json_loads(base64.b64decode(credentials_hash.encode()))
except (ValueError, UnicodeDecodeError):
return None
if not isinstance(decoded, dict):
return None
username = decoded.get("un")
password = decoded.get("pwd")
if isinstance(username, str) and isinstance(password, str):
return cls(username, password)
return None
def get_default_credentials(crdentials: tuple[str, str]) -> Credentials:
"""Return decoded default credentials."""