mirror of
https://github.com/python-kasa/python-kasa.git
synced 2025-12-06 16:18:21 +00:00
Configure mypy to run in virtual environment and fix resulting issues (#989)
For some time I've noticed that my IDE is reporting mypy errors that the pre-commit hook is not picking up. This is because [mypy mirror](https://github.com/pre-commit/mirrors-mypy) runs in an isolated pre-commit environment which does not have dependencies installed and it enables `--ignore-missing-imports` to avoid errors. This is [advised against by mypy](https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker) for obvious reasons: > We recommend avoiding --ignore-missing-imports if possible: it’s equivalent to adding a # type: ignore to all unresolved imports in your codebase. This PR configures the mypy pre-commit hook to run in the virtual environment and addresses the additional errors identified as a result. It also introduces a minimal mypy config into the `pyproject.toml` [mypy errors identified without the fixes in this PR](https://github.com/user-attachments/files/15896693/mypyerrors.txt)
This commit is contained in:
@@ -229,7 +229,7 @@ class XorEncryption:
|
||||
try:
|
||||
from kasa_crypt import decrypt, encrypt
|
||||
|
||||
XorEncryption.decrypt = decrypt # type: ignore[method-assign]
|
||||
XorEncryption.encrypt = encrypt # type: ignore[method-assign]
|
||||
XorEncryption.decrypt = decrypt # type: ignore[assignment]
|
||||
XorEncryption.encrypt = encrypt # type: ignore[assignment]
|
||||
except ImportError:
|
||||
pass
|
||||
|
||||
Reference in New Issue
Block a user