Change state_information to return feature values (#804)

This changes `state_information` to return the names and values of
all defined features.
It was originally a "temporary" hack to show some extra, device-specific
information in the cli tool, but now that we have device-defined
features we can leverage them.
This commit is contained in:
Teemu R
2024-03-26 19:28:39 +01:00
committed by GitHub
parent d63f43a230
commit 35dbda7049
13 changed files with 70 additions and 115 deletions

View File

@@ -1,5 +1,5 @@
"""Module for tapo-branded smart bulbs (L5**)."""
from typing import Any, Dict, List, Optional
from typing import Dict, List, Optional
from ..bulb import Bulb
from ..exceptions import KasaException
@@ -238,25 +238,6 @@ class SmartBulb(SmartDevice, Bulb):
}
)
@property # type: ignore
def state_information(self) -> Dict[str, Any]:
"""Return bulb-specific state information."""
info: Dict[str, Any] = {
# TODO: re-enable after we don't inherit from smartbulb
# **super().state_information
"Is dimmable": self.is_dimmable,
}
if self.is_dimmable:
info["Brightness"] = self.brightness
if self.is_variable_color_temp:
info["Color temperature"] = self.color_temp
info["Valid temperature range"] = self.valid_temperature_range
if self.is_color:
info["HSV"] = self.hsv
info["Presets"] = self.presets
return info
@property
def presets(self) -> List[BulbPreset]:
"""Return a list of available bulb setting presets."""

View File

@@ -334,15 +334,6 @@ class SmartDevice(Device):
ssid = base64.b64decode(ssid).decode() if ssid else "No SSID"
return ssid
@property
def state_information(self) -> Dict[str, Any]:
"""Return the key state information."""
return {
"overheated": self._info.get("overheated"),
"signal_level": self._info.get("signal_level"),
"SSID": self.ssid,
}
@property
def has_emeter(self) -> bool:
"""Return if the device has emeter."""