mirror of
https://github.com/python-kasa/python-kasa.git
synced 2025-08-09 20:24:02 +00:00
Generalize smartdevice child support (#775)
* Initialize children's modules (and features) using the child component negotiation results * Set device_type based on the device response * Print out child features in cli 'state' * Add --child option to cli 'command' to allow targeting child devices * Guard "generic" features like rssi, ssid, etc. only to devices which have this information Note, we do not currently perform queries on child modules so some data may not be available. At the moment, a stop-gap solution to use parent's data is used but this is not always correct; even if the device shares the same clock and cloud connectivity, it may have its own firmware updates.
This commit is contained in:
@@ -16,7 +16,7 @@ import functools
|
||||
import inspect
|
||||
import logging
|
||||
from datetime import datetime, timedelta
|
||||
from typing import Any, Dict, List, Optional, Sequence, Set
|
||||
from typing import Any, Dict, List, Mapping, Optional, Sequence, Set
|
||||
|
||||
from ..device import Device, WifiNetwork
|
||||
from ..deviceconfig import DeviceConfig
|
||||
@@ -183,19 +183,14 @@ class IotDevice(Device):
|
||||
super().__init__(host=host, config=config, protocol=protocol)
|
||||
|
||||
self._sys_info: Any = None # TODO: this is here to avoid changing tests
|
||||
self._children: Sequence["IotDevice"] = []
|
||||
self._supported_modules: Optional[Dict[str, IotModule]] = None
|
||||
self._legacy_features: Set[str] = set()
|
||||
self._children: Mapping[str, "IotDevice"] = {}
|
||||
|
||||
@property
|
||||
def children(self) -> Sequence["IotDevice"]:
|
||||
"""Return list of children."""
|
||||
return self._children
|
||||
|
||||
@children.setter
|
||||
def children(self, children):
|
||||
"""Initialize from a list of children."""
|
||||
self._children = children
|
||||
return list(self._children.values())
|
||||
|
||||
def add_module(self, name: str, module: IotModule):
|
||||
"""Register a module."""
|
||||
@@ -408,15 +403,6 @@ class IotDevice(Device):
|
||||
sys_info = self._sys_info
|
||||
return str(sys_info["model"])
|
||||
|
||||
@property
|
||||
def has_children(self) -> bool:
|
||||
"""Return true if the device has children devices."""
|
||||
# Ideally we would check for the 'child_num' key in sys_info,
|
||||
# but devices that speak klap do not populate this key via
|
||||
# update_from_discover_info so we check for the devices
|
||||
# we know have children instead.
|
||||
return self.is_strip
|
||||
|
||||
@property # type: ignore
|
||||
def alias(self) -> Optional[str]:
|
||||
"""Return device name (alias)."""
|
||||
|
@@ -115,10 +115,12 @@ class IotStrip(IotDevice):
|
||||
if not self.children:
|
||||
children = self.sys_info["children"]
|
||||
_LOGGER.debug("Initializing %s child sockets", len(children))
|
||||
self.children = [
|
||||
IotStripPlug(self.host, parent=self, child_id=child["id"])
|
||||
self._children = {
|
||||
f"{self.mac}_{child['id']}": IotStripPlug(
|
||||
self.host, parent=self, child_id=child["id"]
|
||||
)
|
||||
for child in children
|
||||
]
|
||||
}
|
||||
|
||||
if update_children and self.has_emeter:
|
||||
for plug in self.children:
|
||||
|
Reference in New Issue
Block a user