Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2025-12-04 15:18:19 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix potential infinite loop if incomplete lists returned (#920)

Browse Source 
Fixes the test framework to handle fixtures with incomplete lists better by checking for completeness and overriding the sum. Also adds a pytest-timeout dev dependency with timeout set to 10 seconds. Finally fixes smartprotocol to prevent an infinite loop if incomplete lists ever happens in the real world.

Co-authored-by: Teemu R. <tpr@iki.fi>
This commit is contained in:
Steven B
2024-05-19 10:34:52 +01:00
committed by GitHub
parent 9989d0f6ec
commit 1ba5c73279
6 changed files with 105 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
kasa/tests/fakeprotocol_smart.py
View File

@@ -28,6 +28,8 @@ class FakeSmartTransport(BaseTransport):
*,
list_return_size=10,
component_nego_not_included=False,
warn_fixture_missing_methods=True,
fix_incomplete_fixture_lists=True,
):
super().__init__(
config=DeviceConfig(
@@ -46,6 +48,8 @@ class FakeSmartTransport(BaseTransport):
for comp in self.info["component_nego"]["component_list"]
}
self.list_return_size = list_return_size
self.warn_fixture_missing_methods = warn_fixture_missing_methods
self.fix_incomplete_fixture_lists = fix_incomplete_fixture_lists
@property
def default_port(self):
@@ -220,6 +224,18 @@ class FakeSmartTransport(BaseTransport):
if (params and (start_index := params.get("start_index")))
else 0
)
# Fixtures generated before _handle_response_lists was implemented
# could have incomplete lists.
if (
len(result[list_key]) < result["sum"]
and self.fix_incomplete_fixture_lists
):
result["sum"] = len(result[list_key])
if self.warn_fixture_missing_methods:
pytest.fixtures_missing_methods.setdefault(
self.fixture_name, set()
).add(f"{method} (incomplete '{list_key}' list)")
result[list_key] = result[list_key][
start_index : start_index + self.list_return_size
]
@@ -244,9 +260,10 @@ class FakeSmartTransport(BaseTransport):
"method": method,
}
# Reduce warning spam by consolidating and reporting at the end of the run
if self.fixture_name not in pytest.fixtures_missing_methods:
pytest.fixtures_missing_methods[self.fixture_name] = set()
pytest.fixtures_missing_methods[self.fixture_name].add(method)
if self.warn_fixture_missing_methods:
pytest.fixtures_missing_methods.setdefault(
self.fixture_name, set()
).add(method)
return retval
elif method in ["set_qs_info", "fw_download"]:
return {"error_code": 0}