Require explicit feature type (#1006)

Explicit > implicit. Having this previously would have avoided using a
wrong type for water_alert in the first place.
This commit is contained in:
Teemu R
2024-06-25 18:30:36 +02:00
committed by GitHub
parent 5846bbdbbb
commit 0f5bafaa43
15 changed files with 45 additions and 10 deletions

View File

@@ -43,6 +43,7 @@ class Alarm(SmartModule):
container=self,
attribute_getter="source",
icon="mdi:bell",
type=Feature.Type.Sensor,
)
)
self._add_feature(

View File

@@ -56,6 +56,7 @@ class AutoOff(SmartModule):
container=self,
attribute_getter="auto_off_at",
category=Feature.Category.Info,
type=Feature.Type.Sensor,
)
)

View File

@@ -101,6 +101,7 @@ class Firmware(SmartModule):
container=self,
attribute_getter="current_firmware",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)
self._add_feature(
@@ -111,6 +112,7 @@ class Firmware(SmartModule):
container=self,
attribute_getter="latest_firmware",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)

View File

@@ -29,6 +29,7 @@ class HumiditySensor(SmartModule):
icon="mdi:water-percent",
unit="%",
category=Feature.Category.Primary,
type=Feature.Type.Sensor,
)
)
self._add_feature(

View File

@@ -28,6 +28,7 @@ class ReportMode(SmartModule):
attribute_getter="report_interval",
unit="s",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)

View File

@@ -84,6 +84,7 @@ class TemperatureControl(SmartModule):
container=self,
attribute_getter="mode",
category=Feature.Category.Primary,
type=Feature.Type.Sensor,
)
)

View File

@@ -29,6 +29,7 @@ class TemperatureSensor(SmartModule):
icon="mdi:thermometer",
category=Feature.Category.Primary,
unit_getter="temperature_unit",
type=Feature.Type.Sensor,
)
)
if "current_temp_exception" in device.sys_info:

View File

@@ -30,6 +30,7 @@ class Time(SmartModule):
attribute_getter="time",
container=self,
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)

View File

@@ -36,6 +36,7 @@ class WaterleakSensor(SmartModule):
attribute_getter="status",
icon="mdi:water",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)
self._add_feature(
@@ -47,6 +48,7 @@ class WaterleakSensor(SmartModule):
attribute_getter="alert",
icon="mdi:water-alert",
category=Feature.Category.Primary,
type=Feature.Type.BinarySensor,
)
)

View File

@@ -242,6 +242,7 @@ class SmartDevice(Device):
name="Device ID",
attribute_getter="device_id",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)
if "device_on" in self._info:
@@ -266,6 +267,7 @@ class SmartDevice(Device):
attribute_getter=lambda x: x._info["signal_level"],
icon="mdi:signal",
category=Feature.Category.Info,
type=Feature.Type.Sensor,
)
)
@@ -279,6 +281,7 @@ class SmartDevice(Device):
icon="mdi:signal",
unit="dBm",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)
@@ -291,6 +294,7 @@ class SmartDevice(Device):
attribute_getter="ssid",
icon="mdi:wifi",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)
@@ -318,6 +322,7 @@ class SmartDevice(Device):
attribute_getter="on_since",
icon="mdi:clock",
category=Feature.Category.Debug,
type=Feature.Type.Sensor,
)
)