Mirrored_Repos/python-kasa
1
0
Fork 0
mirror of https://github.com/python-kasa/python-kasa.git synced 2024-12-22 19:23:34 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Include duration when disabling smooth transition on/off (#1313)

Browse Source 
Fixes #1309
This commit is contained in:
Teemu R. 2024-11-26 11:39:31 +01:00 committed by GitHub
parent 69e08c2385
commit 0c755f7120
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
kasa/smart/modules/lighttransition.py
View File

@ -24,6 +24,7 @@ class LightTransition(SmartModule):
REQUIRED_COMPONENT = "on_off_gradually" REQUIRED_COMPONENT = "on_off_gradually"
QUERY_GETTER_NAME = "get_on_off_gradually_info" QUERY_GETTER_NAME = "get_on_off_gradually_info"
MINIMUM_UPDATE_INTERVAL_SECS = 60 MINIMUM_UPDATE_INTERVAL_SECS = 60
# v3 added max_duration, we default to 60 when it's not available
MAXIMUM_DURATION = 60 MAXIMUM_DURATION = 60
# Key in sysinfo that indicates state can be retrieved from there. # Key in sysinfo that indicates state can be retrieved from there.
@ -144,10 +145,22 @@ class LightTransition(SmartModule):
return await self.call("set_on_off_gradually_info", {"enable": enable}) return await self.call("set_on_off_gradually_info", {"enable": enable})
else: else:
on = await self.call( on = await self.call(
"set_on_off_gradually_info", {"on_state": {"enable": enable}} "set_on_off_gradually_info",
{
"on_state": {
"enable": enable,
"duration": self._on_state["duration"],
}
},
) )
off = await self.call( off = await self.call(
"set_on_off_gradually_info", {"off_state": {"enable": enable}} "set_on_off_gradually_info",
{
"off_state": {
"enable": enable,
"duration": self._off_state["duration"],
}
},
) )
return {**on, **off} return {**on, **off}
@ -167,7 +180,6 @@ class LightTransition(SmartModule):
@property @property
def _turn_on_transition_max(self) -> int: def _turn_on_transition_max(self) -> int:
"""Maximum turn on duration.""" """Maximum turn on duration."""
# v3 added max_duration, we default to 60 when it's not available
return self._on_state["max_duration"] return self._on_state["max_duration"]
@allow_update_after @allow_update_after
@ -184,7 +196,7 @@ class LightTransition(SmartModule):
if seconds <= 0: if seconds <= 0:
return await self.call( return await self.call(
"set_on_off_gradually_info", "set_on_off_gradually_info",
{"on_state": {"enable": False}}, {"on_state": {"enable": False, "duration": self._on_state["duration"]}},
) )
return await self.call( return await self.call(
@ -220,7 +232,12 @@ class LightTransition(SmartModule):
if seconds <= 0: if seconds <= 0:
return await self.call( return await self.call(
"set_on_off_gradually_info", "set_on_off_gradually_info",
{"off_state": {"enable": False}}, {
"off_state": {
"enable": False,
"duration": self._off_state["duration"],
}
},
) )
return await self.call( return await self.call(