From 01f3827d733ef822685f7a99042301f5ea89367a Mon Sep 17 00:00:00 2001
From: sdb9696 <51370195+sdb9696@users.noreply.github.com>
Date: Tue, 5 Dec 2023 14:56:29 +0000
Subject: [PATCH] Fix transport retries after close (#568)

---
 kasa/aestransport.py            |  2 ++
 kasa/klaptransport.py           |  2 ++
 kasa/tests/test_klapprotocol.py | 10 +++++-----
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/kasa/aestransport.py b/kasa/aestransport.py
index 6757013d..aefda422 100644
--- a/kasa/aestransport.py
+++ b/kasa/aestransport.py
@@ -88,6 +88,8 @@ class AesTransport(BaseTransport):
 
     async def client_post(self, url, params=None, data=None, json=None, headers=None):
         """Send an http post request to the device."""
+        if not self._http_client:
+            self._http_client = httpx.AsyncClient()
         response_data = None
         cookies = None
         if self._session_cookie:
diff --git a/kasa/klaptransport.py b/kasa/klaptransport.py
index c28cb035..8784d5e9 100644
--- a/kasa/klaptransport.py
+++ b/kasa/klaptransport.py
@@ -118,6 +118,8 @@ class KlapTransport(BaseTransport):
 
     async def client_post(self, url, params=None, data=None):
         """Send an http post request to the device."""
+        if not self._http_client:
+            self._http_client = httpx.AsyncClient()
         response_data = None
         cookies = None
         if self._session_cookie:
diff --git a/kasa/tests/test_klapprotocol.py b/kasa/tests/test_klapprotocol.py
index fe4d1a6c..0b884d16 100644
--- a/kasa/tests/test_klapprotocol.py
+++ b/kasa/tests/test_klapprotocol.py
@@ -32,7 +32,7 @@ class _mock_response:
 async def test_protocol_retries(mocker, retry_count, protocol_class, transport_class):
     host = "127.0.0.1"
     conn = mocker.patch.object(
-        transport_class, "client_post", side_effect=Exception("dummy exception")
+        httpx.AsyncClient, "post", side_effect=Exception("dummy exception")
     )
     with pytest.raises(SmartDeviceException):
         await protocol_class(host, transport=transport_class(host)).query(
@@ -49,8 +49,8 @@ async def test_protocol_no_retry_on_connection_error(
 ):
     host = "127.0.0.1"
     conn = mocker.patch.object(
-        transport_class,
-        "client_post",
+        httpx.AsyncClient,
+        "post",
         side_effect=httpx.ConnectError("foo"),
     )
     with pytest.raises(SmartDeviceException):
@@ -68,8 +68,8 @@ async def test_protocol_retry_recoverable_error(
 ):
     host = "127.0.0.1"
     conn = mocker.patch.object(
-        transport_class,
-        "client_post",
+        httpx.AsyncClient,
+        "post",
         side_effect=httpx.CloseError("foo"),
     )
     with pytest.raises(SmartDeviceException):