2022-04-24 17:38:42 +00:00
|
|
|
import errno
|
2023-12-19 14:11:59 +00:00
|
|
|
import importlib
|
|
|
|
import inspect
|
2019-11-11 19:31:56 +00:00
|
|
|
import json
|
2021-09-26 14:50:58 +00:00
|
|
|
import logging
|
2023-12-19 14:11:59 +00:00
|
|
|
import pkgutil
|
2021-09-24 21:25:43 +00:00
|
|
|
import struct
|
|
|
|
import sys
|
2019-11-11 19:31:56 +00:00
|
|
|
|
2020-05-27 17:02:09 +00:00
|
|
|
import pytest
|
|
|
|
|
2024-01-03 21:46:08 +00:00
|
|
|
from ..aestransport import AesTransport
|
|
|
|
from ..credentials import Credentials
|
2023-12-29 19:17:15 +00:00
|
|
|
from ..deviceconfig import DeviceConfig
|
2020-05-27 17:02:09 +00:00
|
|
|
from ..exceptions import SmartDeviceException
|
2024-01-03 21:46:08 +00:00
|
|
|
from ..klaptransport import KlapTransport, KlapTransportV2
|
2023-12-19 14:11:59 +00:00
|
|
|
from ..protocol import (
|
|
|
|
BaseTransport,
|
|
|
|
TPLinkProtocol,
|
|
|
|
TPLinkSmartHomeProtocol,
|
|
|
|
_XorTransport,
|
|
|
|
)
|
Refactor & add unittests for almost all functionality, add tox for running tests on py27 and py35 (#17)
* Refactor & add unittests for almost all functionality, add tox for running tests on py27 and py35
This commit adds unit tests for current api functionality.
- currently no mocking, all tests are run on the device.
- the library is now compatible with python 2.7 and python 3.5, use tox for tests
- schema checks are done with voluptuous
refactoring:
- protocol is separated into its own file, smartplug adapted to receive protocol worker as parameter.
- cleaned up the initialization routine, initialization is done on use, not on creation of smartplug
- added model and features properties, identity kept for backwards compatibility
- no more storing of local variables outside _sys_info, paves a way to handle state changes sanely (without complete reinitialization)
* Fix CI warnings, remove unused leftover code
* Rename _initialize to _fetch_sysinfo, as that's what it does.
* examples.cli: fix identify call, prettyprint sysinfo, update readme which had false format for led setting
* Add tox-travis for automated testing.
2016-12-16 22:51:56 +00:00
|
|
|
|
|
|
|
|
2020-05-27 17:02:09 +00:00
|
|
|
@pytest.mark.parametrize("retry_count", [1, 3, 5])
|
|
|
|
async def test_protocol_retries(mocker, retry_count):
|
|
|
|
def aio_mock_writer(_, __):
|
|
|
|
reader = mocker.patch("asyncio.StreamReader")
|
|
|
|
writer = mocker.patch("asyncio.StreamWriter")
|
2018-08-08 14:52:03 +00:00
|
|
|
|
2020-05-27 17:02:09 +00:00
|
|
|
mocker.patch(
|
|
|
|
"asyncio.StreamWriter.write", side_effect=Exception("dummy exception")
|
API and tests cleanup (#151)
* Add new cli commands: raw_command and dump_discover
- raw_command can be used to execute raw commands with given parameters
* Useful for testing new calls before implementing them properly
- dump_discover can be used to dump the device discovery information (into a file)
* The discovery is extended to request more modules and methods from devices
* smartlife.iot.dimmer get_dimmer_parameters
* smartlife.iot.common.emeter get_realtime
* smartlife.iot.smartbulb.lightingservice get_light_state
* This is used to dump more information for proper tests, and will also allow better discovery in the future
This commit contains also some documentation updates and dropping click_datetime in favor of click's built-in datetime
* Docstring fixes
* Major API cleanup
Properties shall no more change the state of the device, this work in still in progress, the main goal being making the API more user-friendly and to make implementing new features simpler.
The newly deprecated functionality will remain working and will simply warn the user about deprecation.
Previously deprecated 'features' property and 'identify' method are now finally removed.
Deprecate and replace the following property setters:
* state with turn_on() and turn_off()
* hsv with set_hsv()
* color_temp with set_color_temp()
* brightness with set_brightness()
* led with set_led()
* alias with set_alias()
* mac with set_mac()
And getters:
* state with is_on and is_off
The {BULB,PLUG}_STATE_{ON,OFF} is simplified to STATE_ON and STATE_OFF, UNKNOWN state is removed.
These are now deprecated and will be removed in the future.
* is_on and is_off can be used to check for the state
* turn_on() and turn_off() for changing the device state.
Trying to use functionality not supported by the device will cause SmartDeviceExceptions instead of failing silently and/or returning None.
This includes, e.g., trying to set a color temperature on non-supported bulb.
ValueErrors are raised instead of SmartDeviceExceptions where appropriate (e.g. when trying to set an invalid hsv or brightness).
New enum type DeviceType is added to allow detecting device types without resorting to isinstance() calling. SmartDevice class' device_type property can be used to query the type. is_plug and is_bulb helpers are added.
* Cleanup tests and improve test coverage
* Make writing tests easier by sharing code for common implementations
* Instead of storing test data inside python files, dump-discover based information is used
* This will simplify adding new tests and remove code duplication
* fixtures are based on https://github.com/plasticrake/tplink-smarthome-simulator
* run black on newfakes
* Add HS300 tests and update SmartStrip API according to earlier changes, still WIP
* run black and avoid wildcard imports
* Black on conftest
* bump minimum required version to 3.5
* Rename fixture_tests to test_fixtures for autocollect
* fix typoed type to _type, black
* run black on several files with -79 to fix hound issues
* Fix broken merge on hue
* Fix tests (hue update, pass context to smartdevice), add is_strip property, disable emeter tests for HS300 until a solution for API is found.
* Fix old tests
* Run black on changed files
* Add real HS220 discovery, thanks to @poiyo
* add is_dimmable and is_variable_color_temp to smartdevice class, simplifies interfacing with homeassistant
* add KL120(US) fixture
* Add a simple query cache
This commit adds a simple query cache to speed up the process for users
requesting lots of different properties from the device, as done by the
cli tool as well as homeassistant.
The logic for caching is very simple:
1. A timestamp for last fetch for each module+command is stored alongside the response.
2. If the issued command starts with `get_` and the TTL has not expired, the cache result is returned.
3. Otherwise the cache for the whole corresponding module gets invalidated, the device will be queried and the result will be stored in the cache.
* add deprecation to tox.ini
* make tests pass again
* remove old tests, add flake8 to tox reqs
* run black against pyhs100 module, add it to precommit hooks, fix flake8 configuration to conform to black standards (https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/)
* fix syntax
* cleanup conftest
2019-06-16 21:05:00 +00:00
|
|
|
)
|
2018-08-08 14:52:03 +00:00
|
|
|
|
2020-05-27 17:02:09 +00:00
|
|
|
return reader, writer
|
|
|
|
|
|
|
|
conn = mocker.patch("asyncio.open_connection", side_effect=aio_mock_writer)
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1")
|
2020-05-27 17:02:09 +00:00
|
|
|
with pytest.raises(SmartDeviceException):
|
2023-12-29 19:17:15 +00:00
|
|
|
await TPLinkSmartHomeProtocol(transport=_XorTransport(config=config)).query(
|
|
|
|
{}, retry_count=retry_count
|
|
|
|
)
|
2020-05-27 17:02:09 +00:00
|
|
|
|
|
|
|
assert conn.call_count == retry_count + 1
|
|
|
|
|
|
|
|
|
2022-04-24 17:38:42 +00:00
|
|
|
async def test_protocol_no_retry_on_unreachable(mocker):
|
|
|
|
conn = mocker.patch(
|
|
|
|
"asyncio.open_connection",
|
|
|
|
side_effect=OSError(errno.EHOSTUNREACH, "No route to host"),
|
|
|
|
)
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1")
|
2022-04-24 17:38:42 +00:00
|
|
|
with pytest.raises(SmartDeviceException):
|
2023-12-29 19:17:15 +00:00
|
|
|
await TPLinkSmartHomeProtocol(transport=_XorTransport(config=config)).query(
|
|
|
|
{}, retry_count=5
|
|
|
|
)
|
2022-04-24 17:38:42 +00:00
|
|
|
|
|
|
|
assert conn.call_count == 1
|
|
|
|
|
|
|
|
|
|
|
|
async def test_protocol_no_retry_connection_refused(mocker):
|
|
|
|
conn = mocker.patch(
|
|
|
|
"asyncio.open_connection",
|
|
|
|
side_effect=ConnectionRefusedError,
|
|
|
|
)
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1")
|
2022-04-24 17:38:42 +00:00
|
|
|
with pytest.raises(SmartDeviceException):
|
2023-12-29 19:17:15 +00:00
|
|
|
await TPLinkSmartHomeProtocol(transport=_XorTransport(config=config)).query(
|
|
|
|
{}, retry_count=5
|
|
|
|
)
|
2022-04-24 17:38:42 +00:00
|
|
|
|
|
|
|
assert conn.call_count == 1
|
|
|
|
|
|
|
|
|
|
|
|
async def test_protocol_retry_recoverable_error(mocker):
|
|
|
|
conn = mocker.patch(
|
|
|
|
"asyncio.open_connection",
|
|
|
|
side_effect=OSError(errno.ECONNRESET, "Connection reset by peer"),
|
|
|
|
)
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1")
|
2022-04-24 17:38:42 +00:00
|
|
|
with pytest.raises(SmartDeviceException):
|
2023-12-29 19:17:15 +00:00
|
|
|
await TPLinkSmartHomeProtocol(transport=_XorTransport(config=config)).query(
|
|
|
|
{}, retry_count=5
|
|
|
|
)
|
2022-04-24 17:38:42 +00:00
|
|
|
|
|
|
|
assert conn.call_count == 6
|
|
|
|
|
|
|
|
|
2021-09-24 21:25:43 +00:00
|
|
|
@pytest.mark.parametrize("retry_count", [1, 3, 5])
|
|
|
|
async def test_protocol_reconnect(mocker, retry_count):
|
|
|
|
remaining = retry_count
|
|
|
|
encrypted = TPLinkSmartHomeProtocol.encrypt('{"great":"success"}')[
|
|
|
|
TPLinkSmartHomeProtocol.BLOCK_SIZE :
|
|
|
|
]
|
|
|
|
|
|
|
|
def _fail_one_less_than_retry_count(*_):
|
|
|
|
nonlocal remaining
|
|
|
|
remaining -= 1
|
|
|
|
if remaining:
|
|
|
|
raise Exception("Simulated write failure")
|
|
|
|
|
|
|
|
async def _mock_read(byte_count):
|
|
|
|
nonlocal encrypted
|
|
|
|
if byte_count == TPLinkSmartHomeProtocol.BLOCK_SIZE:
|
|
|
|
return struct.pack(">I", len(encrypted))
|
|
|
|
if byte_count == len(encrypted):
|
|
|
|
return encrypted
|
|
|
|
|
|
|
|
raise ValueError(f"No mock for {byte_count}")
|
|
|
|
|
|
|
|
def aio_mock_writer(_, __):
|
|
|
|
reader = mocker.patch("asyncio.StreamReader")
|
|
|
|
writer = mocker.patch("asyncio.StreamWriter")
|
|
|
|
mocker.patch.object(writer, "write", _fail_one_less_than_retry_count)
|
|
|
|
mocker.patch.object(reader, "readexactly", _mock_read)
|
|
|
|
return reader, writer
|
|
|
|
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1")
|
|
|
|
protocol = TPLinkSmartHomeProtocol(transport=_XorTransport(config=config))
|
2021-09-24 21:25:43 +00:00
|
|
|
mocker.patch("asyncio.open_connection", side_effect=aio_mock_writer)
|
|
|
|
response = await protocol.query({}, retry_count=retry_count)
|
|
|
|
assert response == {"great": "success"}
|
|
|
|
|
|
|
|
|
2021-09-26 14:50:58 +00:00
|
|
|
@pytest.mark.parametrize("log_level", [logging.WARNING, logging.DEBUG])
|
|
|
|
async def test_protocol_logging(mocker, caplog, log_level):
|
|
|
|
caplog.set_level(log_level)
|
|
|
|
logging.getLogger("kasa").setLevel(log_level)
|
|
|
|
encrypted = TPLinkSmartHomeProtocol.encrypt('{"great":"success"}')[
|
|
|
|
TPLinkSmartHomeProtocol.BLOCK_SIZE :
|
|
|
|
]
|
|
|
|
|
|
|
|
async def _mock_read(byte_count):
|
|
|
|
nonlocal encrypted
|
|
|
|
if byte_count == TPLinkSmartHomeProtocol.BLOCK_SIZE:
|
|
|
|
return struct.pack(">I", len(encrypted))
|
|
|
|
if byte_count == len(encrypted):
|
|
|
|
return encrypted
|
|
|
|
raise ValueError(f"No mock for {byte_count}")
|
|
|
|
|
|
|
|
def aio_mock_writer(_, __):
|
|
|
|
reader = mocker.patch("asyncio.StreamReader")
|
|
|
|
writer = mocker.patch("asyncio.StreamWriter")
|
|
|
|
mocker.patch.object(reader, "readexactly", _mock_read)
|
|
|
|
return reader, writer
|
|
|
|
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1")
|
|
|
|
protocol = TPLinkSmartHomeProtocol(transport=_XorTransport(config=config))
|
2021-09-26 14:50:58 +00:00
|
|
|
mocker.patch("asyncio.open_connection", side_effect=aio_mock_writer)
|
|
|
|
response = await protocol.query({})
|
|
|
|
assert response == {"great": "success"}
|
|
|
|
if log_level == logging.DEBUG:
|
|
|
|
assert "success" in caplog.text
|
|
|
|
else:
|
|
|
|
assert "success" not in caplog.text
|
|
|
|
|
|
|
|
|
2023-07-09 23:55:27 +00:00
|
|
|
@pytest.mark.parametrize("custom_port", [123, None])
|
|
|
|
async def test_protocol_custom_port(mocker, custom_port):
|
|
|
|
encrypted = TPLinkSmartHomeProtocol.encrypt('{"great":"success"}')[
|
|
|
|
TPLinkSmartHomeProtocol.BLOCK_SIZE :
|
|
|
|
]
|
|
|
|
|
|
|
|
async def _mock_read(byte_count):
|
|
|
|
nonlocal encrypted
|
|
|
|
if byte_count == TPLinkSmartHomeProtocol.BLOCK_SIZE:
|
|
|
|
return struct.pack(">I", len(encrypted))
|
|
|
|
if byte_count == len(encrypted):
|
|
|
|
return encrypted
|
|
|
|
raise ValueError(f"No mock for {byte_count}")
|
|
|
|
|
|
|
|
def aio_mock_writer(_, port):
|
|
|
|
reader = mocker.patch("asyncio.StreamReader")
|
|
|
|
writer = mocker.patch("asyncio.StreamWriter")
|
|
|
|
if custom_port is None:
|
|
|
|
assert port == 9999
|
|
|
|
else:
|
|
|
|
assert port == custom_port
|
|
|
|
mocker.patch.object(reader, "readexactly", _mock_read)
|
|
|
|
return reader, writer
|
|
|
|
|
2023-12-29 19:17:15 +00:00
|
|
|
config = DeviceConfig("127.0.0.1", port_override=custom_port)
|
|
|
|
protocol = TPLinkSmartHomeProtocol(transport=_XorTransport(config=config))
|
2023-07-09 23:55:27 +00:00
|
|
|
mocker.patch("asyncio.open_connection", side_effect=aio_mock_writer)
|
|
|
|
response = await protocol.query({})
|
|
|
|
assert response == {"great": "success"}
|
|
|
|
|
|
|
|
|
2020-05-27 17:02:09 +00:00
|
|
|
def test_encrypt():
|
|
|
|
d = json.dumps({"foo": 1, "bar": 2})
|
|
|
|
encrypted = TPLinkSmartHomeProtocol.encrypt(d)
|
|
|
|
# encrypt adds a 4 byte header
|
|
|
|
encrypted = encrypted[4:]
|
|
|
|
assert d == TPLinkSmartHomeProtocol.decrypt(encrypted)
|
|
|
|
|
|
|
|
|
|
|
|
def test_encrypt_unicode():
|
|
|
|
d = "{'snowman': '\u2603'}"
|
|
|
|
|
|
|
|
e = bytes(
|
|
|
|
[
|
|
|
|
208,
|
|
|
|
247,
|
|
|
|
132,
|
|
|
|
234,
|
|
|
|
133,
|
|
|
|
242,
|
|
|
|
159,
|
|
|
|
254,
|
|
|
|
144,
|
|
|
|
183,
|
|
|
|
141,
|
|
|
|
173,
|
|
|
|
138,
|
|
|
|
104,
|
|
|
|
240,
|
|
|
|
115,
|
|
|
|
84,
|
|
|
|
41,
|
|
|
|
]
|
|
|
|
)
|
|
|
|
|
|
|
|
encrypted = TPLinkSmartHomeProtocol.encrypt(d)
|
|
|
|
# encrypt adds a 4 byte header
|
|
|
|
encrypted = encrypted[4:]
|
|
|
|
|
|
|
|
assert e == encrypted
|
|
|
|
|
|
|
|
|
|
|
|
def test_decrypt_unicode():
|
|
|
|
e = bytes(
|
|
|
|
[
|
|
|
|
208,
|
|
|
|
247,
|
|
|
|
132,
|
|
|
|
234,
|
|
|
|
133,
|
|
|
|
242,
|
|
|
|
159,
|
|
|
|
254,
|
|
|
|
144,
|
|
|
|
183,
|
|
|
|
141,
|
|
|
|
173,
|
|
|
|
138,
|
|
|
|
104,
|
|
|
|
240,
|
|
|
|
115,
|
|
|
|
84,
|
|
|
|
41,
|
|
|
|
]
|
|
|
|
)
|
|
|
|
|
|
|
|
d = "{'snowman': '\u2603'}"
|
2018-08-08 14:52:03 +00:00
|
|
|
|
2020-05-27 17:02:09 +00:00
|
|
|
assert d == TPLinkSmartHomeProtocol.decrypt(e)
|
2023-12-19 14:11:59 +00:00
|
|
|
|
|
|
|
|
|
|
|
def _get_subclasses(of_class):
|
|
|
|
import kasa
|
|
|
|
|
|
|
|
package = sys.modules["kasa"]
|
|
|
|
subclasses = set()
|
|
|
|
for _, modname, _ in pkgutil.iter_modules(package.__path__):
|
|
|
|
importlib.import_module("." + modname, package="kasa")
|
|
|
|
module = sys.modules["kasa." + modname]
|
|
|
|
for name, obj in inspect.getmembers(module):
|
|
|
|
if inspect.isclass(obj) and issubclass(obj, of_class):
|
|
|
|
subclasses.add((name, obj))
|
|
|
|
return subclasses
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
|
|
"class_name_obj", _get_subclasses(TPLinkProtocol), ids=lambda t: t[0]
|
|
|
|
)
|
|
|
|
def test_protocol_init_signature(class_name_obj):
|
|
|
|
params = list(inspect.signature(class_name_obj[1].__init__).parameters.values())
|
|
|
|
|
2023-12-29 19:17:15 +00:00
|
|
|
assert len(params) == 2
|
2023-12-19 14:11:59 +00:00
|
|
|
assert (
|
|
|
|
params[0].name == "self"
|
|
|
|
and params[0].kind == inspect.Parameter.POSITIONAL_OR_KEYWORD
|
|
|
|
)
|
|
|
|
assert (
|
2023-12-29 19:17:15 +00:00
|
|
|
params[1].name == "transport"
|
|
|
|
and params[1].kind == inspect.Parameter.KEYWORD_ONLY
|
2023-12-19 14:11:59 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
|
|
"class_name_obj", _get_subclasses(BaseTransport), ids=lambda t: t[0]
|
|
|
|
)
|
|
|
|
def test_transport_init_signature(class_name_obj):
|
|
|
|
params = list(inspect.signature(class_name_obj[1].__init__).parameters.values())
|
|
|
|
|
2023-12-29 19:17:15 +00:00
|
|
|
assert len(params) == 2
|
2023-12-19 14:11:59 +00:00
|
|
|
assert (
|
|
|
|
params[0].name == "self"
|
|
|
|
and params[0].kind == inspect.Parameter.POSITIONAL_OR_KEYWORD
|
|
|
|
)
|
|
|
|
assert (
|
2023-12-29 19:17:15 +00:00
|
|
|
params[1].name == "config" and params[1].kind == inspect.Parameter.KEYWORD_ONLY
|
2023-12-19 14:11:59 +00:00
|
|
|
)
|
2024-01-03 21:46:08 +00:00
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
|
|
"transport_class", [AesTransport, KlapTransport, KlapTransportV2, _XorTransport]
|
|
|
|
)
|
|
|
|
async def test_transport_credentials_hash(mocker, transport_class):
|
|
|
|
host = "127.0.0.1"
|
|
|
|
|
|
|
|
credentials = Credentials("Foo", "Bar")
|
|
|
|
config = DeviceConfig(host, credentials=credentials)
|
|
|
|
transport = transport_class(config=config)
|
|
|
|
credentials_hash = transport.credentials_hash
|
|
|
|
config = DeviceConfig(host, credentials_hash=credentials_hash)
|
|
|
|
transport = transport_class(config=config)
|
|
|
|
|
|
|
|
assert transport.credentials_hash == credentials_hash
|