Merge pull request #527 from filipesmedeiros/fix/perf-and-improvements

fix: some perf and other improvements
This commit is contained in:
Kavin 2021-10-11 13:19:51 +01:00 committed by GitHub
commit 18f9cbe060
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 6 deletions

View File

@ -1,6 +1,6 @@
<template> <template>
<MenuDesktop :collapsed="collapsed" :toggleCollapsed="toggleCollapsed" v-if="!isMobile" /> <MenuDesktop :collapsed="collapsed" :toggleCollapsed="toggleCollapsedDebounced" v-if="!isMobile" />
<MenuMobile :collapsed="collapsed" :toggleCollapsed="toggleCollapsed" v-else /> <MenuMobile :collapsed="collapsed" :toggleCollapsed="toggleCollapsedDebounced" v-else />
</template> </template>
<script> <script>
@ -16,11 +16,25 @@ export default {
}, },
props: { props: {
collapsed: Boolean, collapsed: Boolean,
toggleCollapse: Function, toggleCollapsed: Function,
},
data() {
return { toggleCollapsedDisabled: false };
}, },
setup() { setup() {
const isMobile = useIsMobile(); const isMobile = useIsMobile();
return { isMobile }; return { isMobile };
}, },
methods: {
toggleCollapsedDebounced() {
if (!this.toggleCollapsedDisabled) {
this.toggleCollapsed();
this.toggleCollapsedDisabled = true;
setTimeout(() => {
this.toggleCollapsedDisabled = false;
}, 500);
}
},
},
}; };
</script> </script>

View File

@ -17,7 +17,7 @@
<div <div
class="uk-flex uk-flex-middle" class="uk-flex uk-flex-middle"
style="gap: 16px; transition: transform 300ms, gap 300ms;" style="gap: 16px; transition: transform 300ms, gap 300ms;"
:style="collapseText ? 'transform: scale(0); gap: 0;' : 'transition-delay: 170ms'" :style="collapseText ? 'transform: scale3d(0, 0, 0); gap: 0;' : 'transition-delay: 170ms'"
v-if="!hideText" v-if="!hideText"
> >
<img src="/img/pipedPlay.svg" :class="{ 'piped-play': !hideText }" /> <img src="/img/pipedPlay.svg" :class="{ 'piped-play': !hideText }" />
@ -181,7 +181,7 @@ export default {
} }
.sidebar-link span { .sidebar-link span {
transition: font-size 400ms, padding 400ms; transition: font-size 400ms;
} }
.collapse-text .sidebar-link span { .collapse-text .sidebar-link span {
font-size: 0; font-size: 0;

View File

@ -33,7 +33,7 @@
v-if="!isMobile" v-if="!isMobile"
class="uk-flex uk-flex-middle" class="uk-flex uk-flex-middle"
style="gap: 16px; transition: transform 400ms; transform-origin: left;" style="gap: 16px; transition: transform 400ms; transform-origin: left;"
:style="!menuCollapsed ? 'transform: scale(0);' : {}" :style="!menuCollapsed ? 'transform: scale3d(0, 0, 0);' : {}"
> >
<img src="/img/pipedPlay.svg" style="height: 36px;" /> <img src="/img/pipedPlay.svg" style="height: 36px;" />
<img src="/img/piped.svg" /> <img src="/img/piped.svg" />