mirror of
https://github.com/gnif/LookingGlass.git
synced 2026-08-22 07:01:30 +00:00
f9ffce528a
Explorer file copies were invisible to the Helper because the service launched its child with a duplicate of the LocalSystem token and changed only TokenSessionId. The child therefore remained a System-integrity process. Windows filtered Explorer's file clipboard formats across that integrity boundary. Basic text and bitmap formats continued to work. Keep only the SCM service privileged. Obtain the active session user's primary token with WTSQueryUserToken. For elevated accounts, prefer the linked limited token. Validate its session and security properties. Build the user environment and launch the interactive Helper on WinSta0\Default. Gate Helper activation until the service has rechecked the active session and registered the clipboard authority. Use random lifetime, stop, and activation objects owned by the service. Give the target logon SID synchronization access only. Recheck the active console session and service state before activation. Make the lifetime mutex terminate the Helper if the service exits unexpectedly. Restart it when the active session, IDD host, or authority changes. Replace the old process-handle mapping transfer with a device-bound authority protocol on the LGIdd device interface. The service verifies the exact driver host instance, duplicates only section map rights into that process, and registers the session, mapping identifier, and handle. Bind authority lifetime to its WDF file object, revoke it synchronously on cleanup, and poll the driver host identity while the child is active. Restrict the device stack to SYSTEM and isolate LGIdd in a unique UMDF device group. Restrict the shared section to SYSTEM and the target logon SID. Apply a medium mandatory label that prevents low-integrity readers and writers. Map it with read/write rights instead of all access. Give each clipboard mapping a second random authority identifier. Store it only inside the logon-SID-protected mapping and send it in the mandatory HELLO. LGIdd matches it against the service-injected mapping. This authenticates the user Helper without the unsupported UMDF call to GetNamedPipeClientSessionId. Have the Helper verify that its pipe server is in session zero. Extend the pipe endpoint with bounded authentication reads, cancellable overlapped I/O, periodic authorization checks, and explicit disconnects. Serialize authority changes with clipboard attach and detach. Prevent stale cleanup from tearing down a replacement mapping. Disconnect the user pipe immediately when its owning authority is revoked. Run clipboard, OLE, display, configuration, and file access in the user's interactive process. Retain its process token for worker-thread file operations instead of querying and impersonating the desktop user from a System process. Store Helper logs in LocalAppData and grant only the registry rights needed by interactive configuration and UMDF. Keep immediate, stage-specific Win32 and HRESULT diagnostics throughout clipboard capture. Probe CF_HDROP while holding the Win32 clipboard and enumerate the OLE object's advertised file formats. Validate returned storage and fall back to Shell item paths when direct retrieval fails. Validate clipboard sequence changes and defer retries during contention without publishing incomplete clipboard state. Complete the 1 MiB transfer work with full-sized Windows copy buffers. Use full-sized FUSE reads and retain the named 64 KiB X11 chunk limit. Validate the user-writable mapping with CClipboardRing before attaching. The pipe, mapping, and authority protocols change together. LGIdd.dll, the INF, and LGIddHelper.exe must be rebuilt and installed as one matching set.
Client rendering tests
These gtests run the production client with the synthetic test transport,
capture the fully composed framebuffer immediately before presentation, and
compare every pixel with an independent reference implementation.
The default CTest entry starts an isolated headless Weston compositor using Mesa software rendering. It covers:
- BGRA, RGBA, packed BGR32, RGB24, PQ RGBA10, and scRGB RGBA16F;
- odd widths and 24-bit row pitches;
- the Cartesian matrix of every format with full-frame, moving old/new-box, overlapping, maximum-count, invalid, null, and zero-area damage;
- HDR-to-SDR transfer, gamut conversion, and tone mapping.
When run on a color-managed Wayland compositor with a compatible EGL surface, the same tests validate native RGB10A2 or FP16 output. Native PQ tests also check the requested BT.2020 image description, reference white, mastering luminance, MaxCLL, and MaxFALL in the client log.
Building and running
cmake -S client -B client/build \
-DENABLE_TESTS=ON
cmake --build client/build
ctest --test-dir client/build --output-on-failure \
-R render-tests
GoogleTest and Weston are required when ENABLE_TESTS is enabled.
Failed cases retain their capture and client log under /tmp and print the
artifact paths.
To exercise native HDR on the current Wayland session instead of the headless SDR compositor:
client/build/tests/render-tests \
--gtest_filter='*rgba10*:*rgba16f*'
Framebuffer readback verifies the signal produced by Looking Glass. Verifying a compositor's scanout and a physical panel's luminance remains a separate hardware test.