From f8f05c36b832a26290011d046e5668d5b56cb351 Mon Sep 17 00:00:00 2001 From: Geoffrey McRae Date: Fri, 29 Aug 2025 19:25:39 +1000 Subject: [PATCH] [client] egl: remove invalid call to glTexImage2D for dmabuf GL_TEXTURE_EXTERNAL_OES is not a valid target for glTexImage2D and there is no need to "create" the textures as this is done during import by eglCreateImage --- client/renderers/EGL/texture_dmabuf.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/client/renderers/EGL/texture_dmabuf.c b/client/renderers/EGL/texture_dmabuf.c index 17b905d1..c419e108 100644 --- a/client/renderers/EGL/texture_dmabuf.c +++ b/client/renderers/EGL/texture_dmabuf.c @@ -141,22 +141,8 @@ static bool texDMABUFSetup(EGL_Texture * texture) egl_texDMABUFCleanup(texture); glGenTextures(parent->texCount, parent->tex); - for(int i = 0; i < parent->texCount; ++i) - { - glBindTexture(GL_TEXTURE_EXTERNAL_OES, parent->tex[i]); - glTexImage2D(GL_TEXTURE_EXTERNAL_OES, - 0, - texture->format.intFormat, - this->width, - texture->format.height, - 0, - this->format, - texture->format.dataType, - NULL); - } - - glBindTexture(GL_TEXTURE_EXTERNAL_OES, 0); parent->rIndex = -1; + return true; }