[client/idd] input: wait for valid keyboard LED feedback

Do not publish the default all-off LED value until Windows supplies a
real HID output report. Treat the first all-off report as valid and
retain known state across pipe reconnects.

Serialize feedback processing with connection invalidation so a stale
message cannot restore validity after disconnect.
This commit is contained in:
Geoffrey McRae
2026-08-21 13:55:15 +10:00
parent 7ca94e8959
commit efb397bbaf
3 changed files with 23 additions and 13 deletions

View File

@@ -82,9 +82,12 @@ void CInputPipeClient::OnPipeConnected()
{
CSRWExclusiveLock lock(m_feedbackLock);
m_feedbackSequence = 0;
m_feedbackReady = SendKeyboardLEDsLocked();
if (!m_feedbackReady)
m_feedbackReady = true;
if (m_keyboardLEDsValid && !SendKeyboardLEDsLocked())
{
m_feedbackReady = false;
DEBUG_WARN("Failed to report LGInput keyboard LEDs");
}
}
DEBUG_INFO("Connected to the LGIdd input transport");
}
@@ -353,10 +356,11 @@ void CInputPipeClient::UpdateKeyboardLEDs(uint8_t leds)
leds &= mask;
CSRWExclusiveLock lock(m_feedbackLock);
if (m_keyboardLEDs == leds)
if (m_keyboardLEDsValid && m_keyboardLEDs == leds)
return;
m_keyboardLEDs = leds;
m_keyboardLEDs = leds;
m_keyboardLEDsValid = true;
if (m_feedbackReady && !SendKeyboardLEDsLocked())
{
m_feedbackReady = false;