Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2024-11-22 05:27:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[client] X11/i3: write directly into sun_path to avoid strncpy

Browse Source
This commit is contained in:
Geoffrey McRae 2023-11-11 13:47:43 +11:00
parent aa42751743
commit cf51503a54
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/displayservers/X11/wm/i3.c
View File

@ -71,9 +71,9 @@ static bool wm_i3_init(void)
return false; return false;
struct sockaddr_un addr = { .sun_family = AF_UNIX }; struct sockaddr_un addr = { .sun_family = AF_UNIX };
char path[sizeof(addr.sun_path)]; char * path = (char *)&addr.sun_path;
int pathLen; int pathLen;
if ((pathLen = fread(path, 1, sizeof(path), fd)) <= 0) if ((pathLen = fread(path, 1, sizeof(addr.sun_path), fd)) <= 0)
{ {
pclose(fd); pclose(fd);
return false; return false;
@ -91,7 +91,6 @@ static bool wm_i3_init(void)
return false; return false;
} }
strncpy(addr.sun_path, path, sizeof(addr.sun_path));
if (connect(i3.sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) if (connect(i3.sock, (struct sockaddr *)&addr, sizeof(addr)) < 0)
{ {
DEBUG_ERROR("Failed to connect to the i3 IPC socket"); DEBUG_ERROR("Failed to connect to the i3 IPC socket");