Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2026-08-09 00:31:31 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[idd] input: preserve reports under backpressure

Browse Source 
Move named pipe writes off the LGMP input worker so a stalled LGInput
endpoint cannot block queue draining or lease maintenance.

Coalesce motion only under queue pressure while preserving mode, button,
wheel, and keyboard transitions. Reset HID state after discontinuities
and carry all 32 mouse button bits through the pipe and HID reports.
This commit is contained in:
Geoffrey McRae
2026-08-08 23:31:44 +10:00
parent 83c552fb9d
commit ced2fb531e
16 changed files with 820 additions and 382 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
idd/LGCommon/CPipeEndpoint.cpp
View File

@@ -130,15 +130,9 @@ CPipeEndpoint::PipeIoResult CPipeEndpoint::WriteMessage(
const void * message,
DWORD messageSize)
{
HANDLE ioEvent = CreateEventW(nullptr, TRUE, FALSE, nullptr);
if (!ioEvent)
{
DEBUG_ERROR_HR(GetLastError(), "Failed to create named pipe write event");
return PipeIoResult::Error;
}
ResetEvent(m_writeEvent);
OVERLAPPED overlapped = {};
overlapped.hEvent = ioEvent;
overlapped.hEvent = m_writeEvent;
DWORD bytesWritten = 0;
PipeIoResult result = PipeIoResult::Success;
@@ -148,7 +142,7 @@ CPipeEndpoint::PipeIoResult CPipeEndpoint::WriteMessage(
if (error == ERROR_IO_PENDING)
result = WaitForOverlapped(
pipe,
ioEvent,
m_writeEvent,
&overlapped,
&bytesWritten,
WRITE_TIMEOUT_MS);
@@ -174,7 +168,6 @@ CPipeEndpoint::PipeIoResult CPipeEndpoint::WriteMessage(
result = PipeIoResult::Error;
}
CloseHandle(ioEvent);
return result;
}
@@ -197,9 +190,16 @@ bool CPipeEndpoint::Start(
m_mode = mode;
m_messageSize = messageSize;
m_stopEvent = CreateEventW(nullptr, TRUE, FALSE, nullptr);
if (!m_stopEvent)
m_writeEvent = CreateEventW(nullptr, TRUE, FALSE, nullptr);
if (!m_stopEvent || !m_writeEvent)
{
DEBUG_ERROR_HR(GetLastError(), "Failed to create named pipe stop event");
DEBUG_ERROR_HR(GetLastError(), "Failed to create named pipe events");
if (m_writeEvent)
CloseHandle(m_writeEvent);
if (m_stopEvent)
CloseHandle(m_stopEvent);
m_writeEvent = nullptr;
m_stopEvent = nullptr;
return false;
}
@@ -210,6 +210,8 @@ bool CPipeEndpoint::Start(
{
CloseHandle(m_stopEvent);
m_stopEvent = nullptr;
CloseHandle(m_writeEvent);
m_writeEvent = nullptr;
return false;
}
PublishPipe(pipe);
@@ -232,6 +234,8 @@ bool CPipeEndpoint::Start(
CloseHandle(m_stopEvent);
m_stopEvent = nullptr;
CloseHandle(m_writeEvent);
m_writeEvent = nullptr;
return false;
}
@@ -241,6 +245,7 @@ bool CPipeEndpoint::Start(
void CPipeEndpoint::Stop()
{
m_running.store(false);
m_connected.store(false);
if (m_stopEvent)
SetEvent(m_stopEvent);
@@ -270,6 +275,12 @@ void CPipeEndpoint::Stop()
m_stopEvent = nullptr;
}
if (m_writeEvent)
{
CloseHandle(m_writeEvent);
m_writeEvent = nullptr;
}
m_connected.store(false);
}

1
idd/LGCommon/CPipeEndpoint.h
View File

@@ -128,4 +128,5 @@ private:
HANDLE m_pipe = INVALID_HANDLE_VALUE;
HANDLE m_thread = nullptr;
HANDLE m_stopEvent = nullptr;
HANDLE m_writeEvent = nullptr;
};

83
idd/LGCommon/InputPipeProtocol.h
View File

@@ -20,72 +20,59 @@
#pragma once
#include "common/KVMFRInput.h"
#include <stddef.h>
#include <stdint.h>
static constexpr wchar_t LG_INPUT_PIPE_NAME[] =
L"\\\\.\\pipe\\LookingGlassIDDInput";
static constexpr uint32_t LG_INPUT_PIPE_MAGIC = 0x5049474c;
static constexpr uint16_t LG_INPUT_PIPE_VERSION = 2;
static constexpr size_t LG_INPUT_PIPE_MAX_PAYLOAD_SIZE = 64;
static constexpr uint8_t LG_INPUT_MOUSE_BUTTON_MASK = 0x1f;
static constexpr uint16_t LG_INPUT_MOUSE_ABSOLUTE_MAX = 32767;
static constexpr int8_t LG_INPUT_MOUSE_WHEEL_MIN = -127;
static constexpr size_t LG_INPUT_KEYBOARD_KEY_COUNT = 6;
static constexpr uint8_t LG_INPUT_KEYBOARD_USAGE_MAX = 0xe7;
static constexpr uint32_t LG_INPUT_PIPE_MAGIC = 0x5049474c;
static constexpr uint16_t LG_INPUT_PIPE_VERSION = 3;
static constexpr size_t LG_INPUT_PIPE_MAX_PAYLOAD_SIZE = 64;
static constexpr uint16_t LG_INPUT_MOUSE_ABSOLUTE_MAX =
KVMFR_INPUT_MOUSE_ABSOLUTE_MAX;
static constexpr int8_t LG_INPUT_MOUSE_WHEEL_MIN = -127;
static constexpr int32_t LG_INPUT_MOUSE_DELTA_MAX = INT16_MAX * 4;
static constexpr int32_t LG_INPUT_MOUSE_DELTA_MIN = INT16_MIN * 4;
static constexpr int32_t LG_INPUT_MOUSE_WHEEL_MAX = INT8_MAX * 4;
static constexpr int32_t LG_INPUT_MOUSE_WHEEL_MIN_TOTAL =
LG_INPUT_MOUSE_WHEEL_MIN * 4;
static constexpr size_t LG_INPUT_KEYBOARD_KEY_COUNT =
KVMFR_INPUT_KEYBOARD_KEY_COUNT;
static constexpr uint8_t LG_INPUT_KEYBOARD_USAGE_MAX =
KVMFR_INPUT_KEYBOARD_USAGE_MAX;
enum LGInputMouseButton : uint8_t
enum LGInputMouseButton : uint32_t
{
LG_INPUT_MOUSE_BUTTON_LEFT = 1 << 0,
LG_INPUT_MOUSE_BUTTON_RIGHT = 1 << 1,
LG_INPUT_MOUSE_BUTTON_MIDDLE = 1 << 2,
LG_INPUT_MOUSE_BUTTON_BACK = 1 << 3,
LG_INPUT_MOUSE_BUTTON_LEFT = 1 << 0,
LG_INPUT_MOUSE_BUTTON_RIGHT = 1 << 1,
LG_INPUT_MOUSE_BUTTON_MIDDLE = 1 << 2,
LG_INPUT_MOUSE_BUTTON_BACK = 1 << 3,
LG_INPUT_MOUSE_BUTTON_FORWARD = 1 << 4,
};
enum LGInputKeyboardModifier : uint8_t
{
LG_INPUT_KEYBOARD_MODIFIER_LEFT_CONTROL = 1 << 0,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_SHIFT = 1 << 1,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_ALT = 1 << 2,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_GUI = 1 << 3,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_CONTROL = 1 << 0,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_SHIFT = 1 << 1,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_ALT = 1 << 2,
LG_INPUT_KEYBOARD_MODIFIER_LEFT_GUI = 1 << 3,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_CONTROL = 1 << 4,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_SHIFT = 1 << 5,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_ALT = 1 << 6,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_GUI = 1 << 7,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_SHIFT = 1 << 5,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_ALT = 1 << 6,
LG_INPUT_KEYBOARD_MODIFIER_RIGHT_GUI = 1 << 7,
};
enum LGInputPipeMessageType : uint16_t
{
LG_INPUT_PIPE_MESSAGE_MOUSE_ABSOLUTE = 1,
LG_INPUT_PIPE_MESSAGE_MOUSE_RELATIVE = 2,
LG_INPUT_PIPE_MESSAGE_KEYBOARD = 3,
LG_INPUT_PIPE_MESSAGE_KEYBOARD = 3,
};
#pragma pack(push, 1)
struct LGInputPipeMouseRelative
{
uint8_t buttons;
int16_t deltaX;
int16_t deltaY;
int8_t wheel;
};
struct LGInputPipeMouseAbsolute
{
uint8_t buttons;
uint16_t x;
uint16_t y;
int8_t wheel;
};
struct LGInputPipeKeyboard
{
uint8_t modifiers;
uint8_t keys[LG_INPUT_KEYBOARD_KEY_COUNT];
};
struct LGInputPipeMessage
{
uint32_t magic;
@@ -97,11 +84,15 @@ struct LGInputPipeMessage
};
#pragma pack(pop)
static_assert(sizeof(LGInputPipeMouseRelative) == 6,
using LGInputPipeMouseRelative = KVMFRInputMouseRelative;
using LGInputPipeMouseAbsolute = KVMFRInputMouseAbsolute;
using LGInputPipeKeyboard = KVMFRInputKeyboard;
static_assert(sizeof(LGInputPipeMouseRelative) == 16,
"LGInputPipeMouseRelative wire layout changed");
static_assert(sizeof(LGInputPipeMouseAbsolute) == 6,
static_assert(sizeof(LGInputPipeMouseAbsolute) == 16,
"LGInputPipeMouseAbsolute wire layout changed");
static_assert(sizeof(LGInputPipeKeyboard) == 7,
static_assert(sizeof(LGInputPipeKeyboard) == 16,
"LGInputPipeKeyboard wire layout changed");
static_assert(sizeof(LGInputPipeMessage) == 84,
"LGInputPipeMessage wire layout changed");

2
idd/LGCommon/LGCommon.vcxproj
View File

@@ -61,7 +61,7 @@
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
<PreprocessorDefinitions>_ITERATOR_DEBUG_LEVEL=0;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalOptions>/EHsc /D_ATL_NO_WIN_SUPPORT %(AdditionalOptions)</AdditionalOptions>
<AdditionalIncludeDirectories>$(ProjectDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)..\common\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
</ClCompile>
</ItemDefinitionGroup>
<ItemGroup>