Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2024-11-25 23:07:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[host] Windows: don't open the log file, instead show it's location

Browse Source 
Now that it's recommended to run LG as the `SYSTEM` user, launching an
application to read the log file is dangerous as it will be launched
with the same access rights (`SYSTEM`). Instead so as Microsoft
recommends and only present a message box with the information.
This commit is contained in:
Geoffrey McRae 2020-08-11 17:42:00 +10:00
parent 0cf1e27709
commit ca4b1f5592
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
host/platform/Windows/src/platform.c
View File

@ -119,7 +119,13 @@ LRESULT CALLBACK DummyWndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
if (strcmp(logFile, "stderr") == 0) if (strcmp(logFile, "stderr") == 0)
DEBUG_INFO("Ignoring request to open the logFile, logging to stderr"); DEBUG_INFO("Ignoring request to open the logFile, logging to stderr");
else else
ShellExecute(NULL, NULL, logFile, NULL, NULL, SW_SHOWNORMAL); {
/* If LG is running as SYSTEM, ShellExecute would launch a process
* as the SYSTEM user also, for security we will just show the file
* location instead */
//ShellExecute(NULL, NULL, logFile, NULL, NULL, SW_SHOWNORMAL);
MessageBoxA(hwnd, logFile, "Log File Location", MB_OK | MB_ICONINFORMATION);
}
} }
} }
break; break;