Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2024-11-25 06:47:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[client] overlay/msg: fix type for app_msgBoxClose

Browse Source 
It should not be taking a pointer to MsgBoxHandle.

Also changed the type of MsgBoxHandle to prevent similar bugs.
This commit is contained in:
Quantum 2022-03-18 02:13:56 -04:00 committed by Geoffrey McRae
parent c55d0a82f2
commit 75370e464d
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/include/app.h
View File

@ -138,14 +138,14 @@ void app_clipboardRequest(const LG_ClipboardReplyFn replyFn, void * opaque);
*/ */
void app_alert(LG_MsgAlert type, const char * fmt, ...); void app_alert(LG_MsgAlert type, const char * fmt, ...);
typedef void * MsgBoxHandle; typedef struct MsgBoxHandle * MsgBoxHandle;
MsgBoxHandle app_msgBox(const char * caption, const char * fmt, ...); MsgBoxHandle app_msgBox(const char * caption, const char * fmt, ...);
typedef void (*MsgBoxConfirmCallback)(bool yes, void * opaque); typedef void (*MsgBoxConfirmCallback)(bool yes, void * opaque);
MsgBoxHandle app_confirmMsgBox(const char * caption, MsgBoxHandle app_confirmMsgBox(const char * caption,
MsgBoxConfirmCallback callback, void * opaque, const char * fmt, ...); MsgBoxConfirmCallback callback, void * opaque, const char * fmt, ...);
void app_msgBoxClose(MsgBoxHandle * handle); void app_msgBoxClose(MsgBoxHandle handle);
typedef struct KeybindHandle * KeybindHandle; typedef struct KeybindHandle * KeybindHandle;
typedef void (*KeybindFn)(int sc, void * opaque); typedef void (*KeybindFn)(int sc, void * opaque);

2
client/src/app.c
View File

@ -665,7 +665,7 @@ MsgBoxHandle app_confirmMsgBox(const char * caption,
return handle; return handle;
} }
void app_msgBoxClose(MsgBoxHandle * handle) void app_msgBoxClose(MsgBoxHandle handle)
{ {
if (!handle) if (!handle)
return; return;

2
client/src/overlay/msg.c
View File

@ -219,7 +219,7 @@ MsgBoxHandle overlayMsg_show(
return (MsgBoxHandle)msg; return (MsgBoxHandle)msg;
} }
void overlayMsg_close(MsgBoxHandle * handle) void overlayMsg_close(MsgBoxHandle handle)
{ {
if (ll_removeData(l_msg.messages, handle)) if (ll_removeData(l_msg.messages, handle))
freeMsg((struct Msg *)handle); freeMsg((struct Msg *)handle);

2
client/src/overlay/msg.h
View File

@ -32,6 +32,6 @@ MsgBoxHandle overlayMsg_show(
const char * caption, MsgBoxConfirmCallback confirm, void * opaque, const char * caption, MsgBoxConfirmCallback confirm, void * opaque,
const char * fmt, va_list args); const char * fmt, va_list args);
void overlayMsg_close(MsgBoxHandle * handle); void overlayMsg_close(MsgBoxHandle handle);
#endif #endif