Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2024-11-10 08:38:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[common] use correct argument order for calloc

Browse Source 
The signature for calloc is void *calloc(size_t num, size_t size), where num
is the number of elements to allocate, and size is the size. Therefore, to
allocate a single struct, we should pass 1 for num and the size of the struct
as size.

In some places, we use the opposite order, and we should flip it.
This commit is contained in:
Quantum 2021-08-15 18:46:17 -04:00 committed by Geoffrey McRae
parent b7d3bbbd82
commit 4d907cecab
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/src/platform/linux/event.c
View File

@ -39,7 +39,7 @@ struct LGEvent
LGEvent * lgCreateEvent(bool autoReset, unsigned int msSpinTime) LGEvent * lgCreateEvent(bool autoReset, unsigned int msSpinTime)
{ {
LGEvent * handle = (LGEvent *)calloc(sizeof(*handle), 1); LGEvent * handle = (LGEvent *)calloc(1, sizeof(*handle));
if (!handle) if (!handle)
{ {
DEBUG_ERROR("Failed to allocate memory"); DEBUG_ERROR("Failed to allocate memory");

2
common/src/platform/windows/ivshmem.c
View File

@ -160,7 +160,7 @@ bool ivshmemInit(struct IVSHMEM * dev)
return false; return false;
} }
infData = (PSP_DEVICE_INTERFACE_DETAIL_DATA)calloc(reqSize, 1); infData = (PSP_DEVICE_INTERFACE_DETAIL_DATA)calloc(1, reqSize);
infData->cbSize = sizeof(SP_DEVICE_INTERFACE_DETAIL_DATA); infData->cbSize = sizeof(SP_DEVICE_INTERFACE_DETAIL_DATA);
if (!SetupDiGetDeviceInterfaceDetail(devInfoSet, &devInterfaceData, infData, reqSize, NULL, NULL)) if (!SetupDiGetDeviceInterfaceDetail(devInfoSet, &devInterfaceData, infData, reqSize, NULL, NULL))
{ {