Mirrored_Repos/LookingGlass
1
0
Fork 0
mirror of https://github.com/gnif/LookingGlass.git synced 2024-11-13 01:38:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[host] nvfbc: fix resource leak when pointer thread creation fails

Browse Source 
Moving NvFBCToSysSetup to nvfbc_init means that when the pointer thread
fails to be created, NvFBCToSysRelease needs to be called.

To resolve such cleanup issues in the future, we instead call nvfbc_deinit,
which should cleanup everything that needs to be cleaned up. fails.
This commit is contained in:
Quantum 2021-01-30 19:04:13 -05:00 committed by Geoffrey McRae
parent a702c912ae
commit 1b48ac842a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
host/platform/Windows/capture/NVFBC/src/nvfbc.c
View File

@ -65,7 +65,8 @@ struct iface
static struct iface * this = NULL; static struct iface * this = NULL;
static void nvfbc_free(); static bool nvfbc_deinit(void);
static void nvfbc_free(void);
static int pointerThread(void * unused); static int pointerThread(void * unused);
static void getDesktopSize(unsigned int * width, unsigned int * height, unsigned int * dpi) static void getDesktopSize(unsigned int * width, unsigned int * height, unsigned int * dpi)
@ -201,8 +202,7 @@ static bool nvfbc_init(void)
if (!lgCreateThread("NvFBCPointer", pointerThread, NULL, &this->pointerThread)) if (!lgCreateThread("NvFBCPointer", pointerThread, NULL, &this->pointerThread))
{ {
DEBUG_ERROR("Failed to create the NvFBCPointer thread"); DEBUG_ERROR("Failed to create the NvFBCPointer thread");
mouseHook_remove(); nvfbc_deinit();
dwmUnforceComposition();
return false; return false;
} }