From b5e92ce97ce117a65cb0c5f7b63e09a974141933 Mon Sep 17 00:00:00 2001 From: Aaron Kimbrell Date: Mon, 28 Sep 2026 22:33:36 -0500 Subject: [PATCH] fix(messages): swap the names of game messages 1593 and 1594 The client registers SetPropertyModerationStatus as 1594 (GameMessage::SetPropertyModerationStatus sets id 0x63a; no client code uses 1593). The enum had the two names one slot off. Names only; the IDs are unchanged and the pin tests still check both values. In game: nothing changes; neither message is sent yet. Co-Authored-By: Claude Opus 5.5 --- dCommon/dEnums/MessageType/Game.h | 4 ++-- tests/dCommonTests/MessageIdPinTests.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dCommon/dEnums/MessageType/Game.h b/dCommon/dEnums/MessageType/Game.h index b4c44915b..3b6c2c895 100644 --- a/dCommon/dEnums/MessageType/Game.h +++ b/dCommon/dEnums/MessageType/Game.h @@ -1435,8 +1435,8 @@ namespace MessageType { VEHICLE_REMOVE_SLIPPERY_ACTION = 1590, SET_RESURRECT_RESTORE_VALUES = 1591, GET_MASS = 1592, - SET_PROPERTY_MODERATION_STATUS = 1593, - UPDATE_PROPERTY_MODEL_DEFAULTS = 1594, + UPDATE_PROPERTY_MODEL_DEFAULTS = 1593, + SET_PROPERTY_MODERATION_STATUS = 1594, UPDATE_PROPERTYMODEL_COUNT = 1595, GET_PROPERTY_MODEL_COUNT = 1596, IS_PLAYER_LOADED = 1597, diff --git a/tests/dCommonTests/MessageIdPinTests.cpp b/tests/dCommonTests/MessageIdPinTests.cpp index 9676a96fc..99338220f 100644 --- a/tests/dCommonTests/MessageIdPinTests.cpp +++ b/tests/dCommonTests/MessageIdPinTests.cpp @@ -1593,8 +1593,8 @@ static_assert(static_cast(MessageType::Game::VEHICLE_ADD_SLIPPERY_ACTIO static_assert(static_cast(MessageType::Game::VEHICLE_REMOVE_SLIPPERY_ACTION) == 1590); static_assert(static_cast(MessageType::Game::SET_RESURRECT_RESTORE_VALUES) == 1591); static_assert(static_cast(MessageType::Game::GET_MASS) == 1592); -static_assert(static_cast(MessageType::Game::SET_PROPERTY_MODERATION_STATUS) == 1593); -static_assert(static_cast(MessageType::Game::UPDATE_PROPERTY_MODEL_DEFAULTS) == 1594); +static_assert(static_cast(MessageType::Game::UPDATE_PROPERTY_MODEL_DEFAULTS) == 1593); +static_assert(static_cast(MessageType::Game::SET_PROPERTY_MODERATION_STATUS) == 1594); static_assert(static_cast(MessageType::Game::UPDATE_PROPERTYMODEL_COUNT) == 1595); static_assert(static_cast(MessageType::Game::GET_PROPERTY_MODEL_COUNT) == 1596); static_assert(static_cast(MessageType::Game::IS_PLAYER_LOADED) == 1597);