From 3a01b2bce42ae9c5252b4981d5da73c67dfa01ce Mon Sep 17 00:00:00 2001 From: Aaron Kimbrell Date: Tue, 2 Jun 2026 00:09:45 -0500 Subject: [PATCH] fix: update continue-on-error condition in CI workflow and add macOS RelWithDebInfo build preset --- .github/workflows/build-and-test.yml | 2 +- CMakePresets.json | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 3526aec6..e512d411 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -12,7 +12,7 @@ jobs: build-and-test: name: Build & Test (${{ matrix.os }}) runs-on: ${{ matrix.os }} - continue-on-error: ${{ github.event_name != 'push' || !startsWith(github.ref, 'refs/tags/v') }} + continue-on-error: ${{ github.event_name == 'pull_request' }} strategy: matrix: include: diff --git a/CMakePresets.json b/CMakePresets.json index 9806a3a3..2819f320 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -162,6 +162,13 @@ "rhs": "Darwin" }, "binaryDir": "${sourceDir}/build/macos" + }, + { + "name": "macos-relwithdebinfo", + "inherits": ["macos", "relwithdebinfo-config"], + "displayName": "[RelWithDebInfo] MacOS", + "description": "Create a RelWithDebInfo build for MacOS", + "binaryDir": "${sourceDir}/build/macos-relwithdebinfo" } ], "buildPresets": [ @@ -255,7 +262,7 @@ { "name": "macos-relwithdebinfo", "inherits": "default", - "configurePreset": "macos", + "configurePreset": "macos-relwithdebinfo", "displayName": "[RelWithDebInfo] MacOS", "description": "This preset is used to build in release mode with debug info on MacOS", "configuration": "RelWithDebInfo" @@ -374,7 +381,7 @@ { "name": "macos-relwithdebinfo", "inherits": "default", - "configurePreset": "macos", + "configurePreset": "macos-relwithdebinfo", "displayName": "[RelWithDebInfo] MacOS", "description": "Runs all tests on a MacOS configuration", "configuration": "RelWithDebInfo" @@ -603,7 +610,7 @@ "steps": [ { "type": "configure", - "name": "macos" + "name": "macos-relwithdebinfo" }, { "type": "build",