From 0b58b3ec976801f6d8aee71a26dfc6076e027856 Mon Sep 17 00:00:00 2001 From: Aaron Kimbrell Date: Tue, 29 Sep 2026 22:25:28 -0500 Subject: [PATCH] test: clear the game globals the test fixture deletes GameDependenciesTest deleted the logger, config and managers but left the pointers set, so a later test without the fixture (packet capture) logged through a freed logger and crashed when the whole suite ran. Co-Authored-By: Claude Opus 5.5 --- tests/dGameTests/GameDependencies.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/dGameTests/GameDependencies.h b/tests/dGameTests/GameDependencies.h index bd16fb3ee..14b023364 100644 --- a/tests/dGameTests/GameDependencies.h +++ b/tests/dGameTests/GameDependencies.h @@ -73,13 +73,18 @@ protected: void TearDownDependencies() { if (Game::server) delete Game::server; - if (Game::entityManager) delete Game::entityManager; - if (Game::zoneManager) delete Game::zoneManager; + // Cleared too: tests without these fixtures (packet capture) run after them and check them + delete Game::entityManager; + Game::entityManager = nullptr; + delete Game::zoneManager; + Game::zoneManager = nullptr; if (Game::logger) { Game::logger->Flush(); delete Game::logger; + Game::logger = nullptr; } - if (Game::config) delete Game::config; + delete Game::config; + Game::config = nullptr; } EntityInfo info{};